Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default measurement should always be global #84

Open
aomarks opened this issue Jul 10, 2019 · 0 comments
Open

Default measurement should always be global #84

aomarks opened this issue Jul 10, 2019 · 0 comments
Labels
Needs Discussion Needs Discussion

Comments

@aomarks
Copy link
Member

aomarks commented Jul 10, 2019

Currently the default measurement is bench.start/stop when using the built-in server, and first-contentful-paint when using an external URL.

FCP is a particularly bad default, because if you implement either of the other two measurement styles in your code, FCP will still work and return some number, and it's easy to think you are measuring what you implemented instead of FCP.

Let's make the window.tachometerResult global the default in all cases, since it's the most universal (works in all browsers and with both internal/external URLs).

Also, the CLI flag is called "measure", but the JSON config file property is "measurement". These should be the same.

@aomarks aomarks added this to the Sprint 7 July 9-22 milestone Jul 10, 2019
@aomarks aomarks self-assigned this Jul 10, 2019
@aomarks aomarks added the Type: Enhancement New feature or request label Jul 10, 2019
@aomarks aomarks moved this to Todo in Lit Project Board Jan 24, 2022
@aomarks aomarks moved this from Todo to Needs Discussion in Lit Project Board Jan 24, 2022
@aomarks aomarks removed their assignment Jun 21, 2022
@aomarks aomarks removed the Type: Enhancement New feature or request label Jun 24, 2022
@sorvell sorvell moved this from 💬 Needs Discussion to 📋 Triaged in Lit Project Board Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Discussion Needs Discussion
Projects
None yet
Development

No branches or pull requests

1 participant