Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update capitalization of First-party Mode #9902

Open
1 task
benbowler opened this issue Dec 17, 2024 · 0 comments
Open
1 task

Update capitalization of First-party Mode #9902

benbowler opened this issue Dec 17, 2024 · 0 comments
Assignees
Labels
P1 Medium priority Team M Issues for Squad 2 Type: Enhancement Improvement of an existing feature

Comments

@benbowler
Copy link
Collaborator

benbowler commented Dec 17, 2024

Feature Description

We should keep the naming convention the same across the plugin, i.e., in some parts, we name it correctly as First-party mode, but in others, we have called it First-Party Mode, i.e., in the Site Health output. For Settings, we have it as a title case in First-party Mode.

It should be consistently in First-party Mode in the plugin.

@benbowler I just want to add in another situation whwere we need to change the title. From this Asana ticket.

The warning banner displayed when a user can't enable FPM (due to script access or health check) should say "First-party mode" instead of "first-party mode"

Image

Note, the Figma designs have now be updated to represent this change.


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

Implementation Brief

Test Coverage

QA Brief

Changelog entry

@benbowler benbowler added P1 Medium priority Type: Enhancement Improvement of an existing feature Team M Issues for Squad 2 labels Dec 17, 2024
@hussain-t hussain-t self-assigned this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Medium priority Team M Issues for Squad 2 Type: Enhancement Improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants