Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect conversion from tf dtype to jax dtype #49

Open
backpropper opened this issue Feb 2, 2024 · 0 comments
Open

Incorrect conversion from tf dtype to jax dtype #49

backpropper opened this issue Feb 2, 2024 · 0 comments

Comments

@backpropper
Copy link

In class DatasetInputSpecsProvider when converting tf specs to jax

dtype=spec.dtype.as_numpy_dtype())

as_numpy_dtype is considered as a method when it is actually an attribute of tf.dtypes.Dtype (https://www.tensorflow.org/api_docs/python/tf/dtypes/DType#attributes).

The code works for most dtypes but fails to do for tf.string as the returned entity is a pointer to the object np datatype and not the object datatype itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant