Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVG heap graph inconvenient for color blind #766

Open
pavelpatrin opened this issue Apr 12, 2023 · 3 comments
Open

SVG heap graph inconvenient for color blind #766

pavelpatrin opened this issue Apr 12, 2023 · 3 comments
Labels
Priority: p3 Buganizer priority - P3 type: feat Buganizer type - Feature Request

Comments

@pavelpatrin
Copy link

pavelpatrin commented Apr 12, 2023

What version of pprof are you using?

Pprof from Go 1.20.

What operating system and processor architecture are you using?

MacOS with M2 proccessor.

What did you do?

Analyzing SVG graph of heap.

What did you expect to see?

Convenient, understandable colors, e.g. Red-Blue color schema.

What did you see instead?

Indistinguishable Red-Green color schema.

From my side

There are an estimated 300 million people in the world with color vision deficiency. 1 in 12 men are color blind (8%). 1 in 200 women are color blind (0.5%). It is significant. Please thing about changing the color schema to get rid of red-green differences.

@pavelpatrin
Copy link
Author

For example, colors that I cant see.

image

And for example, great colors for me.

Screenshot 2023-04-12 at 20 09 31

#ede6e0 -> #cdcdf0
#b28356 -> #5683b2

@pavelpatrin
Copy link
Author

And even better, replace red with orange!

@aalexand
Copy link
Collaborator

@pavelpatrin Thanks for the report. If the code change for this is simple so that you can prepare a PR, feel free to send it and we can review it.

@Louis-Ye Louis-Ye added type: feat Buganizer type - Feature Request Priority: p3 Buganizer priority - P3 labels May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: p3 Buganizer priority - P3 type: feat Buganizer type - Feature Request
Projects
None yet
Development

No branches or pull requests

3 participants