unknown X-Github-Event in message: schedule

[gerhard]

I am trying to confirm whether we understood this issue correctly.

We are using github.com/google/go-github/v59 v59.0.0 in Dagger v0.15.0 and hitting the following error: unknown X-Github-Event in message: schedule in the context of https://github.com/dagger/dagger/actions/runs/12293242833/job/34319415252

@jacobwgillespie tracked this issue down to:

go-github/github/messages.go

Lines 46 to 48 in 7bc4871

	var (
	// eventTypeMapping maps webhooks types to their corresponding go-github struct types.
	eventTypeMapping = map[string]interface{}{

In Dagger, we are calling this from::

	event, err := github.ParseWebHook(eventType, payload)
	if err != nil {
		slog.Warn("failed to parse $GITHUB_EVENT_PATH", "err", err)
		return labels
	}

My understanding is that ScheduleEvent is missing in eventTypeMapping.

Did we understand this issue correctly?

Follow-up question: are you open to a PR?

---

cc @vito @jedevc @sipsma @grouville @aluzzardi

[gmlewis]

Follow-up question: are you open to a PR?

I'll take the super-easy question first. 😂

Yes, contributions are always welcome.
Please see CONTRIBUTING.md for details.

[gerhard]

Sure thing!

Happy to help get this fixed if we can confirm this is indeed a bug & not user error.

[gmlewis]

Did we understand this issue correctly?

And now for the more difficult question 😅 ...

Yes, it looks like your interpretation is correct.

Happy to help get this fixed if we can confirm this is indeed a bug & not user error.

Wonderful! I would prefer to call this "missing functionality in need of enhancement" as keeping up with the GitHub v3 API has (obviously) been a very long and ongoing process, judging simply from the commit history of this repo. 😂

[gerhard]

Thank you for confirming @gmlewis.

Looking at a fix now.

[gmlewis]

By the way, version v59 is many breaking changes ago, and I know the event-handling code has changed a fair amount since then. Please let me know if you have questions about the breaking changes. You should be able to find a concise summary of every breaking change in each version's release notes (under "Releases").