-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't remove repository ruleset's every Bypass Actors because of serialization issue #3137
Comments
It seems we may need a separate endpoint to explicitly remove all BypassActors since we need the Would you like to put together a PR for this, @lado936, or shall I open this up to other contributors to this repo? |
Better if someone else will work on this, new to Golang and will need way more time i guess |
OK, no problem. This would be a great PR for any new contributor to this repo or a new Go developer. Feel free to volunteer for any issue and the issue can be assigned to you so that others don't attempt to duplicate the work. Please check out our CONTRIBUTING.md guide to get started. (In particular, please remember to Thank you! |
I can take this |
Hello all,
I am using go-github repository ruleset update function from here
but issue is that, if i already have bypassactors set and want to remove all of them, it not applying changes as bypassactors has omitempty set here, if i understand correctly, omitempty must be removed if i want to pass empty list there. Proposing to remove omitempty if there is no case i can't see, why its needed.
The text was updated successfully, but these errors were encountered: