Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IssueEvents missing "performed_via_github_app" value #2945

Closed
Shyclyde opened this issue Oct 1, 2023 · 5 comments
Closed

IssueEvents missing "performed_via_github_app" value #2945

Shyclyde opened this issue Oct 1, 2023 · 5 comments
Assignees

Comments

@Shyclyde
Copy link
Contributor

Shyclyde commented Oct 1, 2023

It would be handy if the IssueEvent struct were to actually contain the "performed_via_github_app" response that appears to already be in the response:

https://docs.github.com/en/rest/issues/events?apiVersion=2022-11-28#list-issue-events

If this is available elsewhere, please lead me in the right direction because I have missed it :)

Use case: this can help determine if any sensitive events on a pull request -- like removing a sensitive label or required reviewer -- were performed by a human or a bot. For instance, if the bots are tightly managed, these events might be expected by a bot, but if a human did this it might need review.

Cheers!

@gmlewis
Copy link
Collaborator

gmlewis commented Oct 1, 2023

Would you like to create a PR, or shall I open this up to our other contributors? (This would also be a great Hacktoberfest PR.)

@Shyclyde
Copy link
Contributor Author

Shyclyde commented Oct 1, 2023

@gmlewis I can work on a PR. I also noticed that depending on the event the "requested_team" attribute might be returned as well that isn't included. I'll block some time out and try my hand at this :)

@gmlewis
Copy link
Collaborator

gmlewis commented Oct 1, 2023

Excellent, thank you, @Shyclyde ! It's yours. 💜
Please take a look at our CONTRIBUTING.md guide for helpful advice.

@Shyclyde
Copy link
Contributor Author

Shyclyde commented Oct 1, 2023

PR: #2946. 👀 are appreciated when available :)

@gmlewis
Copy link
Collaborator

gmlewis commented Oct 3, 2023

Fixed by #2946.

@gmlewis gmlewis closed this as completed Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants