Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Org Required workflow create and update api's should return the workflow object #2756

Closed
avivek opened this issue Apr 14, 2023 · 3 comments · Fixed by #2759
Closed

Org Required workflow create and update api's should return the workflow object #2756

avivek opened this issue Apr 14, 2023 · 3 comments · Fixed by #2759
Labels
Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s).

Comments

@avivek
Copy link
Contributor

avivek commented Apr 14, 2023

The api for required workflow, for both create and update , returns the created workflow object in the response.
Currently the code for these do not return the create object back in an object instead only return the JSON version of these objects.
It would be good to return a typed object as this would enable us to get the details of the created workflow such as name, id etc.
@gmlewis
Copy link
Collaborator

gmlewis commented Apr 14, 2023

Is #2755 related?

@avivek
Copy link
Contributor Author

avivek commented Apr 14, 2023

Hi @gmlewis ,

This is for CreateRequiredWorkflow and UpdateRequiredWorkflow methods in the actions_required_workflows file.
I dont think this is related to 2755.

This was referenced Apr 14, 2023
Closed
Merged
@avivek
Copy link
Contributor Author

avivek commented Apr 14, 2023 •
edited
Loading

Hi @gmlewis ,

I have raised PR#2759 for this.
Pls take a look.
Thanks.

@gmlewis gmlewis added the Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s). label Apr 14, 2023
gmlewis pushed a commit that referenced this issue Apr 17, 2023
@avivek
Update Create/Update methods to return the workflow (#2759)
ff89f86 
Fixes: #2756.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Breaking API Change PR will require a bump to the major version num in next release. Look here to see the change(s).
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Create/Update methods to return the workflow avivek/go-github
2 participants
@avivek @gmlewis