Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scalability: add actuals and limits to the policy model #177

Open
mikouaj opened this issue Jan 27, 2023 · 0 comments
Open

Scalability: add actuals and limits to the policy model #177

mikouaj opened this issue Jan 27, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@mikouaj
Copy link
Member

mikouaj commented Jan 27, 2023

Community Note

  • Please vote on this issue by adding a 👍 reaction
    to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do
    not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

Description

The goal of this feature is to add reporting of the actual value and limits in the policy model after the cluster evaluation. This makes most sense for scalability checks, when user would like to know the actual values and limits, in the evaluation report, even when policy is valid.

From the user perspective, the current console output for a valid scalability policy looks like this:

🔎 [Scalability] gke.scalability.pods: Number of PODs in a cluster
  - projects/gke-policy-demo/locations/europe-central2/clusters/cluster-waw                [ OK ]

With the feature implemented, it could look like below:

🔎 [Scalability] gke.scalability.pods: Number of PODs in a cluster
  - projects/gke-policy-demo/locations/europe-central2/clusters/cluster-waw                [ 120 out of 300k ]

The 120 out of 300k would reman printed in a green colour.
In a JSON report, the policy will be valid isValid: true but new fields, actuals and limit will be present.

References

N/A

@mikouaj mikouaj added the enhancement New feature or request label Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants