Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clasp metrics #353

Open
grant opened this issue Oct 18, 2018 · 9 comments · May be fixed by #757
Open

clasp metrics #353

grant opened this issue Oct 18, 2018 · 9 comments · May be fixed by #757
Labels
good first issue help wanted new command A new command in `clasp`
Milestone
Nice To Have

Comments

@grant
Copy link
Contributor

grant commented Oct 18, 2018 •
edited
Loading

Expected Behavior

Be able to view metrics such as # of executions, active users, active processes.

Maybe a metrics dashboard:

  • clasp metrics

Actual Behavior

Does not exist. We don't use these API methods. Could they be interesting?
@grant grant added help wanted new command A new command in `clasp` labels Oct 18, 2018
@grant grant added this to the Nice To Have milestone Oct 29, 2018
@grant
Copy link
Contributor Author

grant commented Nov 21, 2018

It would be nice if we could see the # of API requests:

https://cloud.google.com/monitoring/api/ref_v3/rest/v3/projects.timeSeries/list?apix_params=%7B%22name%22%3A%22projects%2Fcounterpoint-test%22%2C%22filter%22%3A%22metric.type%20%3D%20%5C%22storage.googleapis.com%2Fapi%2Frequest_count%5C%22%22%2C%22interval.endTime%22%3A%222018-11-22T00%3A12%3A59Z%22%2C%22interval.startTime%22%3A%222018-11-21T00%3A12%3A59Z%22%7D

@takanakahiko
Copy link
Contributor

I want this command!
Currently, We should use GUI on web to check up if there are problems in clasp project .
By using this function, We can investigate the problem with CUI only.

@grant
Copy link
Contributor Author

grant commented Jan 25, 2019

It could be a useful command. I don't have any add-ons with significant users, so it's less useful for me.

It's a good first issue.

Useful for at least for these metrics:

"activeUsers"
"totalExecutions"
"failedExecutions"

@kalmi
Copy link
Contributor

kalmi commented Mar 18, 2020

I decided to pick this up. I am looking for some input on how the output of the command should look like. Does this output style look reasonable?

$ clasp metrics
2020-03-18:  0 users,  0 executions,  0 failed
2020-03-17:  0 users,  0 executions,  0 failed
2020-03-16:  0 users,  0 executions,  0 failed
2020-03-15:  1 users,  1 executions,  0 failed
2020-03-14:  2 users, 21 executions,  2 failed
2020-03-13:  0 users,  0 executions,  0 failed
2020-03-12:  0 users,  0 executions,  0 failed

@oshliaer
Copy link
Contributor

@kalmi

Is it possible get output without any separate signs? : & , are redundant.

@kalmi
Copy link
Contributor

kalmi commented Mar 20, 2020

@contributorpw Thanks, good idea. Dropped them. Which one do you prefer?

2020-03-20 0 users  0 executions 0 failed
2020-03-19 0 users  0 executions 0 failed
2020-03-18 0 users  0 executions 0 failed
2020-03-17 0 users  0 executions 0 failed
2020-03-16 0 users  0 executions 0 failed
2020-03-15 1 user   1 execution  0 failed
2020-03-14 2 users 21 executions 2 failed

2020-03-20  0 users   0 executions  0 failed
2020-03-19  0 users   0 executions  0 failed
2020-03-18  0 users   0 executions  0 failed
2020-03-17  0 users   0 executions  0 failed
2020-03-16  0 users   0 executions  0 failed
2020-03-15  1 user    1 execution   0 failed
2020-03-14  2 users  21 executions  2 failed

2020-03-20 0 users 0 executions 0 failed
2020-03-19 0 users 0 executions 0 failed
2020-03-18 0 users 0 executions 0 failed
2020-03-17 0 users 0 executions 0 failed
2020-03-16 0 users 0 executions 0 failed
2020-03-15 1 user 1 execution 0 failed
2020-03-14 2 users 21 executions 2 failed

Also, is the pluralisation (user/users) a good idea? Or is it just confusing?

@oshliaer
Copy link
Contributor

I'd like the second one.

I can't say something best about pluralisation =) I'd like simple stuff.

@kalmi
Copy link
Contributor

kalmi commented Mar 21, 2020

I am glad. I prefer that one too.

@oshliaer
Copy link
Contributor

@kalmi, I look forward to your suggestions. I would really like this feature.

kalmi added a commit to kalmi/clasp that referenced this issue Mar 23, 2020
@kalmi
Implement metrics command, google#353
18e7ace
kalmi added a commit to kalmi/clasp that referenced this issue Mar 23, 2020
@kalmi
Implement metrics command, google#353
080511c
kalmi added a commit to kalmi/clasp that referenced this issue Mar 23, 2020
@kalmi
Implement metrics command (google#353)
773cb54
@kalmi kalmi linked a pull request Mar 23, 2020 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted new command A new command in `clasp`
Projects
None yet
Milestone
Nice To Have
Development

Successfully merging a pull request may close this issue.

Implement metrics command (google/clasp#353) kalmi/clasp
4 participants
@kalmi @grant @oshliaer @takanakahiko