-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] DoNotOptimize build break with GCC #1675
Comments
Reproducible test case:
Note that changing
to
resolves the build break. |
I'm 99% sure this is working as intended as per the deprecation of non-non-const |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See downstream bug:
When building the following code:
and
the build fails with GCC 7.4.1, GCC 7.5.0, GCC 12.3.0.
The error reported is:
Verified with benchmark 1.8.2 and 1.8.3.
Note that the same code builds fine with CLang.
If this matters,
ParentBasedSampler
andTraceIdRatioBasedSampler
are classes: what is benchmarked here is a call to the constructor.Note how the benchmark header file is different for GCC, with:
The build failure occurs in:
Expected result is a successful build with both GCC and Clang.
The text was updated successfully, but these errors were encountered: