Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reimplement the components GIDHTTPFetcher #319

Open
henryhl22321 opened this issue Jun 14, 2023 · 0 comments
Open

Reimplement the components GIDHTTPFetcher #319

henryhl22321 opened this issue Jun 14, 2023 · 0 comments
Assignees
@henryhl22321
Labels
enhancement New feature or request
Milestone
Clean up the bran...

Comments

@henryhl22321
Copy link
Contributor

Implement the class GIDHTTPFetcher fetches data from an URL endpoint.
GIDSignIn uses this class to revoke granted scopes. GIDProfileDataFetcher uses this class to fetch profile data.
We need this class to encapsulate GTMSessionFetcherServiceProtocol and GTMSessionFetcher so other classes don't need to mock these low level classes in their tests.
@henryhl22321 henryhl22321 added enhancement New feature or request triage Issues that need to be triaged labels Jun 14, 2023
@henryhl22321 henryhl22321 changed the title Reimplement the components httpFetcher Reimplement the components GIDHTTPFetcher Jun 14, 2023
@mdmathias mdmathias removed the triage Issues that need to be triaged label Jul 10, 2023
@henryhl22321 henryhl22321 self-assigned this Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@henryhl22321 henryhl22321

Labels
enhancement New feature or request
Projects
None yet
Milestone
Clean up the branch refactorGSI, refa...
Development

No branches or pull requests
2 participants
@mdmathias @henryhl22321