{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":27146054,"defaultBranch":"master","name":"tools","ownerLogin":"golang","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2014-11-25T21:07:26.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/4314092?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1720384324.0","currentOid":""},"activityList":{"items":[{"before":"febceba19ea960463169f20ff97c02c1a28b4460","after":"71c553722ef44ded9d6ec64f2d2f08c7e813a2a0","ref":"refs/heads/master","pushedAt":"2024-07-09T13:40:32.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"gopls/internal/analysis/fillswitch: use qualified type names\n\nThe message is now of the form \"Add cases for pkg.Type\" when\nthe type is imported from another package.\n\nFixes golang/go#68225\n\nChange-Id: I310f5354d2fb519c1e85d37b313594ccd50353f0\nReviewed-on: https://go-review.googlesource.com/c/tools/+/597275\nAuto-Submit: Alan Donovan \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Robert Findley ","shortMessageHtmlLink":"gopls/internal/analysis/fillswitch: use qualified type names"}},{"before":"3968e70016f3e61138ea79ea07d8606c3948a412","after":"febceba19ea960463169f20ff97c02c1a28b4460","ref":"refs/heads/master","pushedAt":"2024-07-08T17:34:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"copyright: don't skip directories \".\" or \"..\" in checkCopyright\n\nThe checkCopyright function skips directories with names beginning\nwith \".\" (for example \".git\"). But TestToolsCopyright invokes\nthe function on directory \"..\", which means the test is not checking\nanything. To avoid this, make an exception to the \".\" prefix test\nso that \".\" and \"..\" will still be checked.\n\nAlso add a copyright notice to file gopls/doc/assets/assets.go, so\nthe TestToolsCopyright test will pass when it's no longer skipping\neverything.\n\nFixes golang/go#68306\n\nChange-Id: I773dd29113b34f79ce33a02cb91a53664d26b3df\nReviewed-on: https://go-review.googlesource.com/c/tools/+/596736\nReviewed-by: Than McIntosh \nReviewed-by: Robert Findley \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"copyright: don't skip directories \".\" or \"..\" in checkCopyright"}},{"before":"33be3ef892534885002fcfa0ccf4506088a25d59","after":"3968e70016f3e61138ea79ea07d8606c3948a412","ref":"refs/heads/master","pushedAt":"2024-07-08T17:06:44.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"go/analysis/internal/checker: allow for Plan 9 reduced exit codes in tests\n\nBecause process exit status in Plan 9 is a string, not a number,\nthe current Plan 9 implementation of ExitError.ExitCode returns\nonly 1 for any sort of failure, but some tests in this package\nexpect an exit code of 3. Make a special case for Plan 9 to allow\nfor exit codes being only 0 or 1.\n\nFixes golang/go#68290\n\nChange-Id: Ie0c106f70620307a2a0ed89aec742ecdc8daeffc\nReviewed-on: https://go-review.googlesource.com/c/tools/+/596735\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Robert Findley \nReviewed-by: Than McIntosh \nAuto-Submit: Than McIntosh ","shortMessageHtmlLink":"go/analysis/internal/checker: allow for Plan 9 reduced exit codes in …"}},{"before":"0e7ccc0478c322a6b32fb9f74ebfc42e4f965ee9","after":"33be3ef892534885002fcfa0ccf4506088a25d59","ref":"refs/heads/master","pushedAt":"2024-07-07T19:31:52.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"go.mod: update golang.org/x dependencies\n\nUpdate golang.org/x dependencies to their latest tagged versions.\n\nChange-Id: Ia362a291d4c1bad04462b136af09f630c1b5bb05\nReviewed-on: https://go-review.googlesource.com/c/tools/+/596897\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Than McIntosh \nReviewed-by: Dmitri Shuralyov \nAuto-Submit: Gopher Robot ","shortMessageHtmlLink":"go.mod: update golang.org/x dependencies"}},{"before":"fcf54632603b8795667b76d7c373201e9536ed10","after":"0e7ccc0478c322a6b32fb9f74ebfc42e4f965ee9","ref":"refs/heads/master","pushedAt":"2024-07-02T16:56:56.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"gopls/internal/golang: provide version info for stdlib in pkgdoc\n\nThe available versions are provided for functions and methods.\nSame as https://pkg.go.dev/\n\n1. The std lib version is only available for FUNC, METHOD, TYPE. Not\n available for CONST, VAR & FIELD. Because those types do not have\n dedicated HTML element, declarations are shown only as source code.\n2. Introduce css element stdlibVersion which contains the styles needed.\n\nFor golang/go#67159\n\nChange-Id: I4b4f469a858a1aca6598f2abed6f990ab1931b00\nReviewed-on: https://go-review.googlesource.com/c/tools/+/595855\nReviewed-by: Robert Findley \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"gopls/internal/golang: provide version info for stdlib in pkgdoc"}},{"before":"9c895dd76b34c5a87408bbbee4aacab9a22b6b66","after":"0cc407e63f5fdd71499c32afa4c54382c5b48d71","ref":"refs/heads/gopls-release-branch.0.16","pushedAt":"2024-07-01T15:21:28.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"gopls: update go.mod for v0.16.1-pre.1\n\nRemove the replace directive and update x/tools.\n\nFor golang/go#68244\n\nChange-Id: I198a04a24bb96e0b58558440a9541d9cb8648e62\nReviewed-on: https://go-review.googlesource.com/c/tools/+/595955\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Hyang-Ah Hana Kim ","shortMessageHtmlLink":"gopls: update go.mod for v0.16.1-pre.1"}},{"before":"911cda36c77dcf72f2c7d29da88f960f20071272","after":"9c895dd76b34c5a87408bbbee4aacab9a22b6b66","ref":"refs/heads/gopls-release-branch.0.16","pushedAt":"2024-06-28T20:54:48.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"[gopls-release-branch.0.16] gopls/internal/server: add counters to inform v0.17.0\n\nAdd two counters to help inform decisions for gopls@v0.17.0:\n\n- Add a gopls/gotoolchain:{auto,local,other} counter to help us\n understand toolchain upgradability.\n- Add a gopls/telemetryprompt/accepted counter to track telemetry prompt\n acceptance.\n\nFixes golang/go#68240\n\nChange-Id: I8fc06b3a266761dbf7c2781267dfb1235eef1a63\nReviewed-on: https://go-review.googlesource.com/c/tools/+/595560\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Hyang-Ah Hana Kim \n(cherry picked from commit fcf54632603b8795667b76d7c373201e9536ed10)\nReviewed-on: https://go-review.googlesource.com/c/tools/+/595836\nAuto-Submit: Robert Findley ","shortMessageHtmlLink":"[gopls-release-branch.0.16] gopls/internal/server: add counters to in…"}},{"before":"70a59b2f224b125b843a948e205c0792dbff4f22","after":"fcf54632603b8795667b76d7c373201e9536ed10","ref":"refs/heads/master","pushedAt":"2024-06-28T20:28:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"gopls/internal/server: add counters to inform v0.17.0\n\nAdd two counters to help inform decisions for gopls@v0.17.0:\n\n- Add a gopls/gotoolchain:{auto,local,other} counter to help us\n understand toolchain upgradability.\n- Add a gopls/telemetryprompt/accepted counter to track telemetry prompt\n acceptance.\n\nFixes golang/go#68240\n\nChange-Id: I8fc06b3a266761dbf7c2781267dfb1235eef1a63\nReviewed-on: https://go-review.googlesource.com/c/tools/+/595560\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Hyang-Ah Hana Kim ","shortMessageHtmlLink":"gopls/internal/server: add counters to inform v0.17.0"}},{"before":"799a47185df0a37a5e0a95faa9d4b3d693736c5e","after":"70a59b2f224b125b843a948e205c0792dbff4f22","ref":"refs/heads/master","pushedAt":"2024-06-28T18:57:07.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"gopls/doc: respond to Hana's review of CL 583316\n\nAlso:\n- contributor notes on keeping docs up to date;\n- add \"Added in v0.17\" on \"Extract to new file\".\n- various other fixes and tweaks.\n\nChange-Id: I23666654a55190e99109b11cc65ca175a77de65e\nReviewed-on: https://go-review.googlesource.com/c/tools/+/595835\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Robert Findley \nAuto-Submit: Alan Donovan ","shortMessageHtmlLink":"gopls/doc: respond to Hana's review of CL 583316"}},{"before":"2e239ad1ba11fe5e5daa1763388fdd7584ae7c6d","after":"799a47185df0a37a5e0a95faa9d4b3d693736c5e","ref":"refs/heads/master","pushedAt":"2024-06-28T16:12:04.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"gopls/doc: document all of gopls' features\n\nThis CL enumerates and documents each LSP feature\nsupported by gopls so that users can find out:\n- what the tool is capable of,\n- how to use it,\n- what settings affect the feature, and\n- whether their LSP client supports a given feature.\n\nWe plan to provide Code Actions to open the relevant\nsection of the manual, e.g. \"Refactor > Describe refactorings...\"\n\nTo review the markdown, cherrypick this CL then\nrun this command from x/tools:\n\n $ go run rsc.io/cmd/mdweb@latest -a localhost:9876 &\n open http://localhost:9876/gopls/doc/features/README.md\n\nThe topic of completion is left for another day,\nas is support for go.mod files.\n\nUpdates golang/go#54115\n\nChange-Id: I8f7de7571bfe0355b3597487efbc0d7aae7a12d6\nReviewed-on: https://go-review.googlesource.com/c/tools/+/583316\nAuto-Submit: Alan Donovan \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Robert Findley ","shortMessageHtmlLink":"gopls/doc: document all of gopls' features"}},{"before":"7ad3a0df5582723933781d99aeafcd828feef4bd","after":"911cda36c77dcf72f2c7d29da88f960f20071272","ref":"refs/heads/gopls-release-branch.0.16","pushedAt":"2024-06-28T15:08:18.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"[gopls-release-branch.0.16] internal/typeparams: fix crash in interface hover with empty type set\n\nThe logic of typeparams.Free.Has was not handling ErrEmptyTypeSet from\nInterfaceTermSet, leading to a crash.\n\nAlso fix a hover marker in hover/generics.txt that was apparently\nmissing a '@'.\n\nFor the cherry pick: add back the replace directive.\n\nFixes golang/go#68213\n\nChange-Id: I0e264b5c5f5ecc0d09a0b8ab381eb7d7c492c18f\nReviewed-on: https://go-review.googlesource.com/c/tools/+/595555\nAuto-Submit: Robert Findley \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Alan Donovan \n(cherry picked from commit 72edac2ff315a3d7ecf4ef98f13fda6e6af69478)\nReviewed-on: https://go-review.googlesource.com/c/tools/+/595556","shortMessageHtmlLink":"[gopls-release-branch.0.16] internal/typeparams: fix crash in interfa…"}},{"before":"bc15dd8597ecd98beabdb4616a9341905ac3a6da","after":"2e239ad1ba11fe5e5daa1763388fdd7584ae7c6d","ref":"refs/heads/master","pushedAt":"2024-06-27T20:41:51.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"gopls/internal/golang: provide version info for stdlib fields\n\nFor golang/go#67159\n\nChange-Id: I8b8b12949566857f29460675b9dc4d9c6804ff1e\nReviewed-on: https://go-review.googlesource.com/c/tools/+/595336\nAuto-Submit: Hongxiang Jiang \nReviewed-by: Robert Findley \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"gopls/internal/golang: provide version info for stdlib fields"}},{"before":"72edac2ff315a3d7ecf4ef98f13fda6e6af69478","after":"bc15dd8597ecd98beabdb4616a9341905ac3a6da","ref":"refs/heads/master","pushedAt":"2024-06-27T18:36:51.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"gopls/internal/analysis/fillstruct: use package name (not path) in UI\n\nAlso, factor out three instances of the type qualifier as\ntypesinternal.NameRelativeTo.\n\nChange-Id: I22c1e8f89e77a7164c178cf335253a097b9850be\nReviewed-on: https://go-review.googlesource.com/c/tools/+/595119\nReviewed-by: Robert Findley \nLUCI-TryBot-Result: Go LUCI \nAuto-Submit: Alan Donovan ","shortMessageHtmlLink":"gopls/internal/analysis/fillstruct: use package name (not path) in UI"}},{"before":"c0ae6bbd24adc34e4b2ba9ecd75922847f718b27","after":"72edac2ff315a3d7ecf4ef98f13fda6e6af69478","ref":"refs/heads/master","pushedAt":"2024-06-27T18:15:02.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"internal/typeparams: fix crash in interface hover with empty type set\n\nThe logic of typeparams.Free.Has was not handling ErrEmptyTypeSet from\nInterfaceTermSet, leading to a crash.\n\nAlso fix a hover marker in hover/generics.txt that was apparently\nmissing a '@'.\n\nFixes golang/go#68213\n\nChange-Id: I0e264b5c5f5ecc0d09a0b8ab381eb7d7c492c18f\nReviewed-on: https://go-review.googlesource.com/c/tools/+/595555\nAuto-Submit: Robert Findley \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Alan Donovan ","shortMessageHtmlLink":"internal/typeparams: fix crash in interface hover with empty type set"}},{"before":"02faa7b9b32c81299f0c08eb249eec0d186eb76a","after":"7ad3a0df5582723933781d99aeafcd828feef4bd","ref":"refs/heads/gopls-release-branch.0.16","pushedAt":"2024-06-27T18:13:46.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"[gopls-release-branch.0.16] gopls/internal/golang/completion: fix package clause completion suffix\n\nCL 585275 introduced a call to completion.Surrounding.Suffix that\nexposed a latent bug in package clause completions: the completion\ncontent was not being correctly computed as containing the cursor.\n\nFix the heuristics for completing at \"package|\", so that the\nsurrounding content is correct.\n\nAs a result of this change the 'editRegexp' from some completion tests\nnow no longer includes the newline, which also seems more correct.\n\nFixes golang/go#68169\n\nChange-Id: I32ea20a7f9f0096aef85ed77c64d3b4dfeedef45\nReviewed-on: https://go-review.googlesource.com/c/tools/+/594796\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Hyang-Ah Hana Kim \nAuto-Submit: Robert Findley \n(cherry picked from commit 008ed2c6914c648cfabe7050f1209a6bb9a51dc7)\nReviewed-on: https://go-review.googlesource.com/c/tools/+/595575","shortMessageHtmlLink":"[gopls-release-branch.0.16] gopls/internal/golang/completion: fix pac…"}},{"before":"5cc2d0b12cd3eee183bbd2f3a901418f482d0579","after":"c0ae6bbd24adc34e4b2ba9ecd75922847f718b27","ref":"refs/heads/master","pushedAt":"2024-06-27T18:11:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"gopls/internal/golang: splitlines: s/parameter/arguments/ in CallExpr\n\n(Another terminological nitpick that I missed until reading the docs.)\n\nAlso, commentary.\n\nChange-Id: I8d985234637224be7b921bdaa8113baa9c54be66\nReviewed-on: https://go-review.googlesource.com/c/tools/+/595118\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Robert Findley \nAuto-Submit: Alan Donovan ","shortMessageHtmlLink":"gopls/internal/golang: splitlines: s/parameter/arguments/ in CallExpr"}},{"before":"69160777a97d008c78dbaf1e72c69b657c3a9db3","after":"5cc2d0b12cd3eee183bbd2f3a901418f482d0579","ref":"refs/heads/master","pushedAt":"2024-06-27T17:53:29.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"gopls/internal/golang: splitlines: remove workaround for golang/go#68202\n\nThere's no need for splitlines to handle FuncDecl since it\nhandles FuncType... now that the bug in PathEnclosingInterval\nis fixed.\n\nUpdates golang/go#68202\n\nChange-Id: I3c96535b87c62e5d2a5b68ec66fed7df50b5d6c4\nReviewed-on: https://go-review.googlesource.com/c/tools/+/595196\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Robert Findley ","shortMessageHtmlLink":"gopls/internal/golang: splitlines: remove workaround for golang/go#68202"}},{"before":"8fa4173de3eb0507050500109922ff5012c5d635","after":"69160777a97d008c78dbaf1e72c69b657c3a9db3","ref":"refs/heads/master","pushedAt":"2024-06-27T17:53:11.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"gopls/internal/golang: don't panic when findKeyword fails\n\nAs the existing comment attests, this can happen in the wild.\nJust skip it and move on.\n\n+ a test\n\nFixes golang/go#68205\n\nChange-Id: I3227b0ce7ffacf3c8b4bbf2180a10e218bf87aa3\nReviewed-on: https://go-review.googlesource.com/c/tools/+/595117\nReviewed-by: Robert Findley \nAuto-Submit: Alan Donovan \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"gopls/internal/golang: don't panic when findKeyword fails"}},{"before":"b9a361aa9c807427e27a18e9ea78a4035fbfa61c","after":"8fa4173de3eb0507050500109922ff5012c5d635","ref":"refs/heads/master","pushedAt":"2024-06-27T14:23:38.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"gopls/internal/server: conditionally prompt for telemetry\n\nPreviously, VS Code Go extension conditionally asked gopls to\nconsider to prompt, only if\n * it thinks telemetry data was logged for 7days+, and\n * the user is selected (based on hash of vscode cliet id)\n\nThis change implements the condition checking inside gopls,\nso we can enable prompting for other editor users and simplify\nvscode-go's code.\n\nThe prompt file format is changed.\n old format: \n new format: \n\nwhere\n - creation_unix_time is the guessed telemetry start time (unix time)\n - token is a random integer in [1, 1000], which is used in sampling\n decision.\n\nThis CL adds environment variables to control the creation_unix_time\nand token values in integration testing. They are also useful for\nmanual testing, and for VS Code Go prompt logic migration.\nVS Code Go extension had been used a vscode machine id hash\nand kept its observed telemetry start time in memento. The env vars\ncan be used to forward the info to gopls.\n\nFor golang/go#67821\n\nChange-Id: I13d2bf6d43ea1e5ef8ebec7eb2f89fc9af8a8db7\nReviewed-on: https://go-review.googlesource.com/c/tools/+/589517\nReviewed-by: Robert Findley \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"gopls/internal/server: conditionally prompt for telemetry"}},{"before":"dd9d554b34065b45c493d890a81e78365eee66f0","after":"b9a361aa9c807427e27a18e9ea78a4035fbfa61c","ref":"refs/heads/master","pushedAt":"2024-06-27T02:53:18.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"gopls/internal/golang: provide version info for stdlib methods\n\nFor golang/go#67159\n\nChange-Id: If3d09a39e8bf0a5ab61dc0953d7250ad75525372\nReviewed-on: https://go-review.googlesource.com/c/tools/+/595135\nReviewed-by: Robert Findley \nReviewed-by: Alan Donovan \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"gopls/internal/golang: provide version info for stdlib methods"}},{"before":"3db1ddbb319faf6ad52294a42f309601d9eb351a","after":"dd9d554b34065b45c493d890a81e78365eee66f0","ref":"refs/heads/master","pushedAt":"2024-06-26T20:54:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"go/ast/astutil: PathEnclosingInterval: add missing FuncType nodes\n\nThe special case for FuncDecl > FuncType added long ago had the\neffect of eliding FuncType from the returned path. Add it back.\n\nFixes golang/go#68202\n\nChange-Id: I7dd1bc5c81c89af9b1f388154bec4e910d0fb2d6\nReviewed-on: https://go-review.googlesource.com/c/tools/+/595195\nReviewed-by: Robert Findley \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"go/ast/astutil: PathEnclosingInterval: add missing FuncType nodes"}},{"before":"008ed2c6914c648cfabe7050f1209a6bb9a51dc7","after":"3db1ddbb319faf6ad52294a42f309601d9eb351a","ref":"refs/heads/master","pushedAt":"2024-06-26T18:10:30.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"gopls/internal/golang: provide available version info in stdlib hover\n\nVersion is only available for the types of Var, Func, Const & Type.\n\nFor golang/go#67159\n\nChange-Id: I77f95ccb6027914440ec7a2ea5338318c0f88e60\nReviewed-on: https://go-review.googlesource.com/c/tools/+/594875\nReviewed-by: Alan Donovan \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Robert Findley ","shortMessageHtmlLink":"gopls/internal/golang: provide available version info in stdlib hover"}},{"before":"b297f5a4df64a4a9707b002478328a63d35a74c0","after":"008ed2c6914c648cfabe7050f1209a6bb9a51dc7","ref":"refs/heads/master","pushedAt":"2024-06-26T17:42:42.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"gopls/internal/golang/completion: fix package clause completion suffix\n\nCL 585275 introduced a call to completion.Surrounding.Suffix that\nexposed a latent bug in package clause completions: the completion\ncontent was not being correctly computed as containing the cursor.\n\nFix the heuristics for completing at \"package|\", so that the\nsurrounding content is correct.\n\nAs a result of this change the 'editRegexp' from some completion tests\nnow no longer includes the newline, which also seems more correct.\n\nFixes golang/go#68169\n\nChange-Id: I32ea20a7f9f0096aef85ed77c64d3b4dfeedef45\nReviewed-on: https://go-review.googlesource.com/c/tools/+/594796\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Hyang-Ah Hana Kim \nAuto-Submit: Robert Findley ","shortMessageHtmlLink":"gopls/internal/golang/completion: fix package clause completion suffix"}},{"before":"b5bfa9cc3f8a6e3ad9a05d63679fe9327631e41a","after":"b297f5a4df64a4a9707b002478328a63d35a74c0","ref":"refs/heads/master","pushedAt":"2024-06-26T17:06:31.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"gopls/internal/golang: s/return values/results/\n\n(A terminological nitpick.)\n\nChange-Id: I4ecd8141c547d0f385623159e32f9ce58e3e672a\nReviewed-on: https://go-review.googlesource.com/c/tools/+/595155\nAuto-Submit: Alan Donovan \nCommit-Queue: Alan Donovan \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Robert Findley ","shortMessageHtmlLink":"gopls/internal/golang: s/return values/results/"}},{"before":"02912f74a517eb125d9a666f4a0e68a7b98f9449","after":"b5bfa9cc3f8a6e3ad9a05d63679fe9327631e41a","ref":"refs/heads/master","pushedAt":"2024-06-26T14:45:57.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"gopls/internal/fuzzy: move the fuzzy package to gopls\n\nWhile reviewing CL 592519, I had to pause to confirm that the fuzzy\nmatcher is only used by gopls, and so we are therefore free to change\nits matching heuristics.\n\nMove the library to the gopls module to make this relationship more\napparent.\n\nChange-Id: I2d097fe68cfb6c83d82a09c63eddd8b7462f6ec7\nReviewed-on: https://go-review.googlesource.com/c/tools/+/595115\nReviewed-by: Alan Donovan \nLUCI-TryBot-Result: Go LUCI \nAuto-Submit: Robert Findley ","shortMessageHtmlLink":"gopls/internal/fuzzy: move the fuzzy package to gopls"}},{"before":"e7f294d2579763718e202a354f8114f0b6e4f6c4","after":"02912f74a517eb125d9a666f4a0e68a7b98f9449","ref":"refs/heads/master","pushedAt":"2024-06-26T14:39:44.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"gopls/internal/cache: lift package caching to forEachPackage\n\nFor some reason this solution didn't occur to me in CL 512636. By\nlifting this handling out of forEachPackageInternal, we simplify the\nlogic of type checking.\n\nChange-Id: Ie8738d04aa5e1e4811f978f2ebe2d1cfc3b839b0\nReviewed-on: https://go-review.googlesource.com/c/tools/+/591918\nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Alan Donovan \nAuto-Submit: Robert Findley ","shortMessageHtmlLink":"gopls/internal/cache: lift package caching to forEachPackage"}},{"before":"480a22df0438d2da77e8528a068233caa9e752c2","after":"e7f294d2579763718e202a354f8114f0b6e4f6c4","ref":"refs/heads/master","pushedAt":"2024-06-26T14:21:20.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"gopls/matcher: don't give bonus to case insensitive match\n\nPreviously the user given pattern \"A\" would match \"Ant\" and \"ant\"\nequally well. Now it will match \"Ant\" better than \"ant\".\n\nThere already was a case sensitive match bonus, but it was combined\nwith a \"head\" character bonus, so \"Ant\" got the case sensitive bonus,\nand \"ant\" got the head match bonus (and they tied).\n\nTweak the head match bonus to not apply if the pattern is case\nsensitive. In other words, if the user is explicitly putting capital\nletters in the pattern, don't give a bonus if the pattern char's case\ndiffers from that of the candidate char.\n\nFor example, if the pattern is \"Foo\", the \"F\" no longer gets a bonus\nfor matching the \"f\" in \"fooBar\".\n\nI tweaked the test to test strict relative ranking. Previously it\nallowed adjacent test inputs to have the same score, but I wanted to\ntest that \"N\" matches \"Name\" strictly better than \"name\".\n\nFixes golang/go#64224\n\nChange-Id: Ibce21985d5c904167cec239d62a4f53e814a9b08\nReviewed-on: https://go-review.googlesource.com/c/tools/+/592519\nReviewed-by: Alan Donovan \nReviewed-by: Robert Findley \nLUCI-TryBot-Result: Go LUCI ","shortMessageHtmlLink":"gopls/matcher: don't give bonus to case insensitive match"}},{"before":"315127076e5cc2f83067919a16a1dd352270b8cc","after":"480a22df0438d2da77e8528a068233caa9e752c2","ref":"refs/heads/master","pushedAt":"2024-06-26T14:07:40.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"gopls/completion: don't take address of interfaces for \"%p\" values\n\nWhen completing printf calls, we previously only preferred\npointers and slices. This meant to make an interface object acceptable\nfor \"%p\", we would take its address to turn it into a pointer.\n\nChange \"%p\" to also prefer interface types in addition to chan, map, and\nfunc, which all have pointer semantics. Note that interface types\ndon't necessarily contain pointers, but they might, so tacking on \"&\"\nautomatically is annoying.\n\nFixes golang/go#65609\n\nChange-Id: Idf2ba9cf27fa4ea8e721396cded5a7743d79807b\nReviewed-on: https://go-review.googlesource.com/c/tools/+/593575\nReviewed-by: Robert Findley \nLUCI-TryBot-Result: Go LUCI \nAuto-Submit: Robert Findley \nReviewed-by: Alan Donovan ","shortMessageHtmlLink":"gopls/completion: don't take address of interfaces for \"%p\" values"}},{"before":"850c7c3070cd5da0bea7299d8b61a7ce0fd706f7","after":"315127076e5cc2f83067919a16a1dd352270b8cc","ref":"refs/heads/master","pushedAt":"2024-06-26T14:07:14.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"gopls/internal: add code action \"extract declarations to new file\"\n\nThis code action moves selected code sections to a newly created file within the same package. The created filename is chosen as the first {function, type, const, var} name encountered. In addition, import declarations are added or removed as needed.\n\nFixes golang/go#65707\n\nChange-Id: I3fd45afd3569e4e0cee17798a48bde6916eb57b8\nGitHub-Last-Rev: e551a8a24f3dc5ea51e1c54f9f28c147c7669b11\nGitHub-Pull-Request: golang/tools#479\nReviewed-on: https://go-review.googlesource.com/c/tools/+/565895\nAuto-Submit: Alan Donovan \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Robert Findley \nReviewed-by: Alan Donovan ","shortMessageHtmlLink":"gopls/internal: add code action \"extract declarations to new file\""}},{"before":"dc341221fd9cc0c370af7a8abbaf889295633097","after":"850c7c3070cd5da0bea7299d8b61a7ce0fd706f7","ref":"refs/heads/master","pushedAt":"2024-06-25T18:01:39.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"gopherbot","name":"GopherBot","path":"/gopherbot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/8566911?s=80&v=4"},"commit":{"message":"gopls: skip failing tests on wasm/wasip1\n\nAdd skips as appropriate to TestFreeRefs and TestDriverConformance.\n\nAlso add a skip for a preexisting failure on wasip1: golang/go#64725.\n\nFixes golang/go#68163\nUpdates golang/go#64725\n\nChange-Id: I2827160bad6627755f213e4b8b54d53333d2d98d\nReviewed-on: https://go-review.googlesource.com/c/tools/+/594895\nAuto-Submit: Robert Findley \nLUCI-TryBot-Result: Go LUCI \nReviewed-by: Dmitri Shuralyov \nReviewed-by: Dmitri Shuralyov ","shortMessageHtmlLink":"gopls: skip failing tests on wasm/wasip1"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEerh6PQA","startCursor":null,"endCursor":null}},"title":"Activity · golang/tools"}