Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go test not working #24

Open
bhanuc opened this issue Nov 2, 2016 · 4 comments
Open

Go test not working #24

bhanuc opened this issue Nov 2, 2016 · 4 comments

Comments

@bhanuc
Copy link

bhanuc commented Nov 2, 2016

Here is the output log of the ibgwstart file -
https://gist.github.com/bhanuc/29af6844868eb4afc19e5e7a1a09065f
It might contain the issue, but I was unable to pinpoint the exact issue.
On running go test, I just get a series of
2016/11/02 21:21:44 Waited 5 seconds for reply channel 0xc8200ae240
What is the expected amount of time I am supposed to wait for the test to succeed.
Update:
I manually entered the username and password on the 5th line of ibgwstart file:
Updated log: https://gist.github.com/bhanuc/a417eb70ceaee46a6884315ddc324d62
Updated test log: https://gist.github.com/bhanuc/99564fe1fd46c01d0c66cd4ecfe26b3c

The updated start log shows no error but the test log tells a different story

@nothize
Copy link
Contributor

nothize commented Jun 12, 2017

I think this is related to (8a68c49):
https://github.com/gofinance/ib/blob/master/manager.go#L128

I debugged and found that one goroutine stuck at https://github.com/gofinance/ib/blob/master/manager.go#L103 waiting for the errors channel forever because errors has been set to nil that reading from a nil channel blocks forever.

Removing errors = nil fixes the test.

@nothize
Copy link
Contributor

nothize commented Jun 13, 2017

Pull Request #26 is submitted to address this issue.

@nothize
Copy link
Contributor

nothize commented Jun 30, 2017

Moved to #28

@nothize
Copy link
Contributor

nothize commented Aug 3, 2017

PR #28 has been merged to master. @bhanuc Could you re-test from master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants