Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent behavior when undoing animation bezier movements upon selection of different animations #93859

Open
CookieBadger opened this issue Jul 2, 2024 · 1 comment · May be fixed by #93860
Open

Inconsistent behavior when undoing animation bezier movements upon selection of different animations #93859

CookieBadger opened this issue Jul 2, 2024 · 1 comment · May be fixed by #93860
Labels
bug topic:animation topic:editor

Comments

@CookieBadger
Copy link
Contributor

Tested versions

  • Reproducible in 4.2.1 and master (9425535)

System information

Windows 10

Issue description

When manipulating bezier keys and then selecting a different Animation, or a different AnimationPlayer, bad things are bound to happen on undo and redo, due to the animation_bezier_editor referencing the currently selected animation in the undo methods.

Steps to reproduce

  1. Select AnimationPlayer, go into bezier view and move a key
  2. Select a different AnimationPlayer
  3. Undo (observe an index out of bounds error in the output)
  4. Redo (observe that the key is now transferred to the currently selected animation)

Minimal reproduction project (MRP)

AnimationTestProject2.zip
@AThousandShips AThousandShips changed the title Fix inconsistent behavior when undoing animation bezier movements upon selection of different animations Inconsistent behavior when undoing animation bezier movements upon selection of different animations Jul 2, 2024
@CookieBadger
Copy link
Contributor Author

damn, that was fast :D

I am working on a fix for this.

@CookieBadger CookieBadger linked a pull request Jul 2, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug topic:animation topic:editor
Projects
None yet
Milestone
No milestone
2 participants
@CookieBadger @AThousandShips