Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Everything is now optional by default in v3.0.0 #123

Open
sambegin opened this issue May 18, 2022 · 1 comment
Open

Everything is now optional by default in v3.0.0 #123

sambegin opened this issue May 18, 2022 · 1 comment

Comments

@sambegin
Copy link

Moving to V3, everything is optional by default: v2.4.0...v3.0.0#files_bucket

Is there a reason for that? I feel like status , amount, currency perhaps? Can a big rework of typing be done so it 100% represents your documentation? For typescript developers, this is unfortunately hardly usable.

It's also gonna take me a long time to fix those in small bunch of PR like those : #114 and you guys probably have the best knowledge to know what is required or not 💪

Thank you!

@szastupov
Copy link
Contributor

Hi @sambegin ! Our types are generated from our schema, which marks certain fields as required. Before 3.0, all fields were wrongfully marked as required and 3.0 switched to defaulting to optional and only marking fields required only if specified by schema. I'll try to forward this question to the teams who are responsible for specific parts of the schema to see why some fields are not explicitly required while in practice they are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants