Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ElementHolder #355

Open
vernonr3 opened this issue Feb 2, 2023 · 0 comments
Open

ElementHolder #355

vernonr3 opened this issue Feb 2, 2023 · 0 comments

Comments

@vernonr3
Copy link
Contributor

vernonr3 commented Feb 2, 2023

This parameter type ElementHolder allows almost anything to be passed in (for example the code in views.go doesn't check for the existence of elements within the structs that are inspected in subsidiary functions.
This lead to unexpected crashes as tests (e.g. views_test.go) were developed. More seriously it could lead to unexpected crashes/bugs if more code uses these functions. More defensive coding might be worth adopting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vernonr3