Replies: 4 comments 13 replies
-
|
Take a look at https://pkg.go.dev/github.com/go-co-op/gocron#example-Scheduler.CustomTime It was added for this purpose to allow testing with your own logic for time. |
Beta Was this translation helpful? Give feedback.
-
|
Thanks, John: I was aware of this, however it's NOT a working example, and I have the gist, which does NOT seem to work. I need further insight into |
Beta Was this translation helpful? Give feedback.
-
|
I see your gist now. When I find some time to look into it I will. At first blush it looks reasonable. |
Beta Was this translation helpful? Give feedback.
-
|
I spend some time today digging more, and found a new package for mocking time ("go.chromium.org/luci/common/clock/testclock") With this new gist, I can have a fake clock that runs faster than wall clock, and it works to some extent. See the test result here: Basically I schedule a job running every 2sec, and inside the box was the mock clock (which runs 60x faster): each trigger reports 2 min inside, the test stops after 10 triggering. However, ideally I want a slight different idea: I want the scheduler to schedule the events inside the box (following the mock clock). Do you think your scheduler package can somehow achieve this? Thanks |
Beta Was this translation helpful? Give feedback.
-
|
then does it make sense to expose |
Beta Was this translation helpful? Give feedback.
-
|
Sleep is called in a few places but not for the regular scheduling of job intervals, hence why it is on the time wrapper interface. I added the afterfunc override ability here -> https://github.com/go-co-op/gocron/pull/381/files and the reason it's not on the time interface is that it's not a function on time.Time but rather a separate function and I don't want to force someone who is using the customTime to also have to implement the afterFunc. |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for the work! I will take a look later today and see how I can achieve my goal on my end. Also may I ask when your code can be included in release 1.16.4? I would assume unless I switch my repo to use the head of |
Beta Was this translation helpful? Give feedback.
-
|
https://github.com/go-co-op/gocron/releases/tag/v1.17.0 there it is |
Beta Was this translation helpful? Give feedback.
-
|
Hey, John: I got some time to look into this. Thanks for the code, but it seems I still cannot make the whole thing work. For other mock clock or To solve this once and for all, we should use an interface for timer and Another alternative: similar to your example, is to change the duration on-the-fly. However, this only applies to the It seems tricker than I expected: you really need to abstract out all concrete structs from |
Beta Was this translation helpful? Give feedback.
-
This example is not working anymore. Only one line is printed, which means the job is only executed once. At the time of writing, testing the scheduler for periodical jobs is quite impracticable, as there's no working example anywhere. |
Beta Was this translation helpful? Give feedback.
-
|
Mocking of time isn’t great in v1 of gocron. I’m planning to have a better design in v2 that supports actually mocking and manipulating time. I’m planning to use https://github.com/jonboulle/clockwork, but open to suggestions if there is something better. |
Beta Was this translation helpful? Give feedback.
-
|
@JohnRoesler Actually, after some debugging and digging in the package main
import (
"log"
"time"
"github.com/go-co-op/gocron"
)
type myCustomTime struct {
now *time.Time
}
var _ gocron.TimeWrapper = (*myCustomTime)(nil)
func (m myCustomTime) Now(_ *time.Location) time.Time {
return *m.now
}
func (m myCustomTime) Sleep(_ time.Duration) {
time.Sleep(time.Second)
return
}
func (m myCustomTime) Unix(sec int64, nsec int64) time.Time {
panic("implement me")
}
func main() {
now := time.Now()
mct := myCustomTime{
now: &now,
}
s := gocron.NewScheduler(time.UTC)
s.CustomTime(mct)
s.CustomTimer(func(d time.Duration, f func()) *time.Timer {
now = now.Add(time.Minute * 10)
d = time.Second
return time.AfterFunc(d, f)
})
_, err := s.Every(10).Minutes().Do(func() {
log.Printf("hello: fake time is %s", now.String())
})
if err != nil {
log.Println(err)
}
s.StartAsync()
time.Sleep(10 * time.Second)
s.Stop()
}The reason is in the call to the job job.setTimer(s.timer(nr, func() {
if !next.dateTime.IsZero() {
for {
n := s.now().UnixNano() - next.dateTime.UnixNano()
if n >= 0 {
break
}
select {
case <-s.executor.ctx.Done():
case <-time.After(time.Duration(n)):
}
}
}
s.runContinuous(job)
}))
}The custom timer function is called for each job execution and the difference between the current time (mocked) and the time of the next scheduled execution should always be a positive number in order to exit from loop and perform the re-scheduling. About the last point, it's still not clear to me the need to wait for a "negative time duration", since by design of Golang |
Beta Was this translation helpful? Give feedback.
-
Hey, maintainer:
I'm trying to write a scheduler with gocron, and it seems to be serving my needs just fine in production. However, I want to do some testing to ensure my own scheduling logic makes sense and ideally I would like to try mock time: actually the ability to mock time is one of the primary reason I picked gocron in the first place.
I tried to use
github.com/benbjohnson/clockto mock time, with this gist. Essentially I want to test with the mock time, a scheduler with a periodic job of 2sec, can run (at least) 10 times during a mock period of 30sec.Ideally I would like the time progression to be invisible by the application code, so that we can play god in the time manipulation.
However, even the underlying
clocklibrary seems to do its job, the testing code (the gist) doesn't work as expected. It would be great if you can:gocron.TimeWrapper: currently there is no working example.Thanks.
Kevin.
Beta Was this translation helpful? Give feedback.
All reactions