Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DNS provider for Abion #2112

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Add DNS provider for Abion #2112

wants to merge 2 commits into from

Conversation

ldez
Copy link
Member

@ldez ldez commented Feb 13, 2024 •
edited
Loading

  • adds a description to your PR
  • have a homogeneous design with the other providers
  • add tests (units)
  • add tests ("live")
  • add a provider descriptor
  • generate CLI help, documentation, and readme.
  • be able to do: (and put the output of this command to a comment) 
    make build
rm -rf .lego

ABION_API_KEY=yyyy \
./dist/lego -m [email protected] --dns abion -d *.example.com -d example.com -s https://acme-staging-v02.api.letsencrypt.org/directory run
    Note the wildcard domain is important.
  • pass the linter
  • do go mod tidy

Ping @Gaardsholt, can you run the command (with your domain, email, and credentials)?

How to test this PR?
  1. You need Go
  2. Checkout the PR: 
    git clone https://github.com/ldez/lego.git
cd lego
git checkout feat/abion
  3. Compile lego:
    • if you have make: make build
    • if you don't make make: go build -o dist/lego ./cmd/lego
  4. Run the following command with your own information (email, domain, credentials): 
    ABION_API_KEY=yyyy \
./dist/lego -m [email protected] --dns abion -d *.example.com -d example.com -s https://acme-staging-v02.api.letsencrypt.org/directory run
    The wildcard domain is important
  5. Before each run of the command, you should clean your local environment: 
    rm -rf .lego

Closes #2111

@ldez ldez mentioned this pull request Feb 17, 2024
Merged
@ldez
Copy link
Member Author

ldez commented Feb 23, 2024

@Gaardsholt do you have some time to test this PR?

I already tested the API part.

@Gaardsholt
Copy link

@ldez I'm waiting for API access, as soon as I get it, I will test it :)

@ldez
Copy link
Member Author

ldez commented Apr 15, 2024

@Gaardsholt any news?

1 similar comment
@ldez
Copy link
Member Author

ldez commented Aug 28, 2024

@Gaardsholt any news?

@Gaardsholt
Copy link

@Gaardsholt any news?

I am so sorry about this!
I have totally forgotten about this, I will try and get this done during the upcoming week!

@ldez ldez force-pushed the feat/abion branch 2 times, most recently from 41cde67 to fa9c4fc Compare October 14, 2024 13:27
@ldez ldez force-pushed the feat/abion branch 2 times, most recently from b61a556 to 48942d2 Compare October 26, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/dnsprovider enhancement state/need-user-tests Need users to test functionality
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for provider: Abion
2 participants
@ldez @Gaardsholt