Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dangerous code in ANTLR gdlc.g #1805

Open
GillesDuvert opened this issue Apr 13, 2024 · 1 comment
Open

Remove dangerous code in ANTLR gdlc.g #1805

GillesDuvert opened this issue Apr 13, 2024 · 1 comment
Assignees
@GillesDuvert
Labels
antlr Requires antlr know-how Badly Written / Designed code cleanup WIP Work In Progress: PR acceptance will be considered when this label is removed.

Comments

@GillesDuvert
Copy link
Contributor

One needs to remove the patch made by Marc in gdlc.g (revision 6a61cee on Aug 23,2014). This patch explictely introduces (in primary_expr_deref) a compilable C++ code that depend on the tokenSets generated by ANTLR, which in return depend on the changes made elsewhere in gdlc.g . This is not maintainable and apparently is the cause of some slowness, if not errors.
Primary tests without this patch show now problems in all test at our disposal and may also show a slight increase of compilation speed. Not to speak about simplifying the maintainance of this important code, the base language interpretor.
@GillesDuvert GillesDuvert self-assigned this Apr 13, 2024
@GillesDuvert GillesDuvert added antlr Requires antlr know-how cleanup WIP Work In Progress: PR acceptance will be considered when this label is removed. Badly Written / Designed code labels Apr 13, 2024
@GillesDuvert
Copy link
Contributor Author

In previous text read "show NO problems" instead of "show now problems"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GillesDuvert GillesDuvert

Labels
antlr Requires antlr know-how Badly Written / Designed code cleanup WIP Work In Progress: PR acceptance will be considered when this label is removed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GillesDuvert