Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Filter away CC-Bracket-Annotations #46

Open
dennis-mb opened this issue Nov 17, 2023 · 1 comment
Open

[Feature Request] Filter away CC-Bracket-Annotations #46

dennis-mb opened this issue Nov 17, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@dennis-mb
Copy link

I would like to have a toggle for each subtitel stream whether to filter away anything within square brackets and the brackets themselves.

Netflix seems to offer english subs only with CC annotations like "[birds singing]" which are annoying to me (and perhaps many other people). Especially if using english subtitels for english shows as non-native speaker, but hearing enabled person, for better comprehension.

@gmertes
Copy link
Owner

gmertes commented Nov 24, 2023

Hi, thanks for the suggestion! It goes a little against the core of the extension, which is to only show the subtitles as they are provided by Netflix. In some regions Netflix will provide both regular and CC English subs, making such a toggle useless. Also, I'm pretty sure there can be more in a CC sub than just brackets, sometimes there are music notes or other symbols, so would have to be thorough with this.

I'm not totally against the idea, but I'd like a more transparent implementation. Instead of a toggle I suggest to automatically insert a filtered English sub in the subtitles list whenever it is missing. Might even go a step further and do this for all languages, but it would have to be really robust first.

I will explore the above, but it is going to have to go on my todo list for now as I will be away in the coming weeks. If anyone wants to have a go at this I welcome a PR.

@gmertes gmertes added the enhancement New feature or request label Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants