-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for extra out-of-region languages #29
Comments
resolves gmertes#29
resolves gmertes#29
Using older version of cadmium player with
|
When an extra language is activated as primary sub, these parameters are set in
The way I could view/modify parameters in requests for now is by hooking |
resolves gmertes#29 tested with cadium-playercore 6.0033.414.911, 6.0034.588.911, 6.0038.181.911
I tried to mimic user behaviour (clicking primary subtitles on menu) to trigger manifest request and get download urls for extra subtitles. Primary subtitle is restored to original setting after manifest request triggered. It has some problems:
I put my implementation here in case someone is interested in it. |
#36 is currently a partial fix, it requires the user to manually activate the primary subs first before it's available as secondary sub.
Amazing! I am really temped to also pull this in if we can polish it and deal with those problems. One thing I would suggest is to keep the original hydrated languages at the top of the list and add a horizontal line under them, so that the layout is the same as the primary list. I'll have some time in the coming weeks to play around with your fork! |
Netflix has added support for extra out-of-region subtitle languages. These subs are present in the manifest, but they are missing their download url. For in-region subtitles we get the download url from
manifest.timedtexttracks[].ttDownloadables
, but this field is empty for the extra subs. I have done only limited investigation at the time of writing, but I don't see the download url anywhere in other fields.What's interesting is that once you select one of the extra languages as primary sub, the
ttDownloadables
for that track is populated with a download url - making that language available as secondary sub (and it will show up on refresh). This may be a deliberate obfuscation. It also indicates thatttDownloadables
is still used by the player when activating the extra subs, we just need to figure out where it gets populated from. If we cannot easily get a complete list of download urls, we could potentially mimic user behaviour and just cycle through the primary subs one by one to intercept all urls (not ideal but 🤷♀️).I'm opening this issue to document the implementation of support for out of region languages, and request help from the community. Feedback, suggestions and PR are very much appreciated.
The text was updated successfully, but these errors were encountered: