Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add secondary sub menu to extension button popup #2

Open
gmertes opened this issue Oct 4, 2021 · 1 comment
Open

Add secondary sub menu to extension button popup #2

gmertes opened this issue Oct 4, 2021 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@gmertes
Copy link
Owner

gmertes commented Oct 4, 2021

I would like to add a backup secondary language list to the settings page. So that if Netflix ever breaks the layout again, we can fall back to this menu in the settings page and the extension can keep working.

If possible, the backup menu should only be visible if the regular injection in the web-player fails (bonus: show a warning on screen to make the user aware of this). It may not be possible to check this reliably (because the secondary menu is only injected when the subtitle menu is visible). As an alternative, the menu should be small and not add bulk to the settings page. Layout should be kept as simple and small as possible, ideally just a select box with languages.

PR welcome.

@gmertes gmertes added enhancement New feature or request help wanted Extra attention is needed labels Oct 4, 2021
@Rachel-Tan0
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants