Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method waitVanish does not raise FindFailed exception after seconds timeout #150

Open
ghost opened this issue May 13, 2019 · 2 comments
Open

Comments

@ghost
Copy link

ghost commented May 13, 2019

The doc says:
waitVanish(pattern, seconds=None)[source]
Waits until the specified pattern is not visible on screen.

If seconds pass and the pattern is still visible, raises FindFailed exception. Sikuli supports OCR search with a text parameter. This does not (yet).

But it does not raise it because this line is commented out in the source code.
if match: return False # self._findFailedHandler(FindFailed("Pattern '{}' did not vanish".format(pattern.path)))

@glitchassassin
Copy link
Owner

This was corrected for Sikuli compatibility, but the documentation was not updated. The functionality itself is correct. Thanks for the catch!

@glitchassassin
Copy link
Owner

Fix has moved to develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant