Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't remove extra images or videos from other instances #1975

Open
Freeplayg opened this issue Nov 28, 2022 · 9 comments · May be fixed by #2621
Open

Don't remove extra images or videos from other instances #1975

Freeplayg opened this issue Nov 28, 2022 · 9 comments · May be fixed by #2621

Comments

@Freeplayg
Copy link

Freeplayg commented Nov 28, 2022

Pitch

Allow posts that have more than 4 images to be shown.

Someone suggested for the the fourth square to include a sub-grid (with a max of 4), with an overlay showing the amount of more images there are. And then users can see the rest by scrolling through the image popup.

Another way of showing this in the UI could be to have the images scroll horizontally. Something like this, but with an arrow button to scroll
image

Motivation

For example, Pixelfed (and some other platforms) lets users add more than 4 images. But people on Mastodon will only see the first 4, creating a disconnect.

(issue copied from mastodon#19454)

@kescherCode
Copy link

This is currently on my bucket list as a configurable instance wide limit.

The ruby code for this requires not a lot of modification. However, the UI does, since you need to both tell a user "there's more than four images here" and a way to actually view thumbnails for all of them (the "fullscreen" view would not be an issue, as that requires little to no changes as far as I know).

@Freeplayg
Copy link
Author

I've found that Mastodon also removes extra videos, it is currently capped at just one.

@Freeplayg Freeplayg changed the title Allow for showing of more than 4 images from other instances Don't remove extra images or videos from other instances Nov 17, 2023
@ShadowJonathan
Copy link

Mentioning mastodon#14336 since that is the new issue.

Does anyone have a patch they could merge in?

@ShadowJonathan
Copy link

@sinoru, since you have a fork (as you mentioned in the above thread), do you want to merge in a patch that ups the limit from 4 to 32?

Also, if you have a patch that alters the frontend (something similar to what freeplay shows), or if you know something that does, that'd be amazing.

cc @TheEssem since I vaguely remember chuckya having this, or something adjacent to it.

@sinoru
Copy link

sinoru commented Feb 14, 2024

@ShadowJonathan
I change it hard coded, So It should be some nicer implementation required. (Limit can be changed by instance)

I can try some thing like: mastodon#27833
But, G doesn't like it.

@ShadowJonathan
Copy link

This is why I'm suggesting to make that PR to the glitch-soc fork, gargon won't add it, but maybe Claire would like it for glitch-soc

@sinoru
Copy link

sinoru commented Feb 14, 2024

@ShadowJonathan Okay. I will try in this week.

@sinoru
Copy link

sinoru commented Feb 15, 2024

@ShadowJonathan I created the PR for this.

@ShadowJonathan
Copy link

Thank you, the maintainer is a bit busy at the moment, but i'm pretty sure it will be considered eventually :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants