Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-447: make sure dz gives the same results as nbins #448

Merged
merged 3 commits into from
Nov 21, 2024
Merged

gh-447: make sure dz gives the same results as nbins #448

merged 3 commits into from
Nov 21, 2024

Conversation

paddyroddy
Copy link
Member

Closes #447. Discovered in #436.

Values are generated within the half-open interval [start, stop)

Due to the use of np.arange one needs to add the step to zmax in the function call.

@paddyroddy
gh-447: make sure dz gives the same results as nbins
d0ac6af 
Closes #447. Discovered in #436.

> Values are generated within the half-open interval [start, stop)

Due to the use of `np.arange` one needs to add the step to `zmax` in the
function call.
@paddyroddy paddyroddy added the bug Something isn't working label Nov 21, 2024
@paddyroddy paddyroddy self-assigned this Nov 21, 2024
ntessore
ntessore reviewed Nov 21, 2024
View reviewed changes
glass/observations.py Outdated Show resolved Hide resolved
@paddyroddy paddyroddy merged commit 6fbeb97 into main Nov 21, 2024
16 checks passed
@paddyroddy paddyroddy deleted the paddy/issue-447 branch November 21, 2024 12:07
Saransh-cpp pushed a commit that referenced this pull request Nov 26, 2024
@paddyroddy @Saransh-cpp
gh-447: make sure dz gives the same results as nbins (#448)
bb970b9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntessore ntessore ntessore approved these changes

@Saransh-cpp Saransh-cpp Awaiting requested review from Saransh-cpp

Assignees

@paddyroddy paddyroddy

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fixed_zbins gives different results based on dz or nbins input
2 participants
@paddyroddy @ntessore