Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-271: add tests for glass.observations #436

Merged
merged 37 commits into from
Nov 27, 2024
Merged

gh-271: add tests for glass.observations #436

merged 37 commits into from
Nov 27, 2024

Conversation

paddyroddy
Copy link
Member

@paddyroddy paddyroddy commented Nov 18, 2024 •
edited
Loading

Closes #271. Adds tests for the glass.observations module. Coverage going up 5.3% to 67%.

@paddyroddy paddyroddy added enhancement New feature or request infrastructure Project infrastructure: dev tools, packaging, etc. testing Work is related to testing labels Nov 18, 2024
@paddyroddy paddyroddy self-assigned this Nov 18, 2024
@paddyroddy paddyroddy mentioned this pull request Nov 20, 2024
Closed
@paddyroddy
Merge branch 'main' into paddy/issue-271
5da3f65
@paddyroddy
Remove # type: ignore[attr-defined]
e7b4302
@paddyroddy
Add nbins test
af76e03
@paddyroddy
gh-447: make sure dz gives the same results as nbins
d0ac6af 
Closes #447. Discovered in #436.

> Values are generated within the half-open interval [start, stop)

Due to the use of `np.arange` one needs to add the step to `zmax` in the
function call.
@paddyroddy paddyroddy mentioned this pull request Nov 21, 2024
Merged
@paddyroddy paddyroddy changed the base branch from main to paddy/issue-447 November 21, 2024 11:22
Base automatically changed from paddy/issue-447 to main November 21, 2024 12:07
An error occurred while trying to automatically change base from paddy/issue-447 to main November 21, 2024 12:07
@paddyroddy paddyroddy marked this pull request as ready for review November 21, 2024 15:49
Saransh-cpp
Saransh-cpp approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@Saransh-cpp Saransh-cpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks great!

@paddyroddy
Copy link
Member Author

Going to merge to get the testing in to assess coverage

@paddyroddy paddyroddy merged commit efa7d22 into main Nov 27, 2024
16 checks passed
@paddyroddy paddyroddy deleted the paddy/issue-271 branch November 27, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Saransh-cpp Saransh-cpp Saransh-cpp approved these changes

@ntessore ntessore Awaiting requested review from ntessore

Assignees

@paddyroddy paddyroddy

Labels
enhancement New feature or request infrastructure Project infrastructure: dev tools, packaging, etc. testing Work is related to testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add/review tests for glass.observations
2 participants
@paddyroddy @Saransh-cpp