gh-405: array API support for glass.core.algorithm
#423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Perhaps, before merging any changes, we should figure out a way to
|
paddyroddy
reviewed
Nov 20, 2024
| msg = "input arrays should belong to the same array library" | ||
| raise ValueError(msg) | ||
|
|
||
| xp = a.__array_namespace__() |
There was a problem hiding this comment.
Was talking to @matt-graham and he wondered if we should be using array-api-compat here. That should solve the cupy issue. I believe only NumPy and JAX are stable at this point.
There was a problem hiding this comment.
The CuPy support will become official in their next major release (v14) where they will start supporting NumPy v2. I hope they push the release in the next 3 months, so that we don't have to experiment with array-api-compat.
Saransh-cpp
force-pushed
the
saransh/array-api-core
branch
from
b67c4f5
to
6e8ef45
Compare
Saransh-cpp
force-pushed
the
saransh/array-api-core
branch
from
6e8ef45
to
761795c
Compare
Saransh-cpp
force-pushed
the
saransh/array-api-test
branch
from
fa75b7a
to
1b0d92b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP (not draft to test array API in the CI)
Has some caveats that I am working on, but opening this PR for visibility.
Closes: #405