-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gitify does not send any notification from github.com if it is not able to access to GitHub Enterprise server. #423
Comments
It doesn't just not send notifications, but it also replaces the entire UI with a "Something went wrong" page so I can't even check the notifications myself. |
Notifications and displaying the window both require information from the server. If it can't contact the server, it doesn't know what to display. Beyond that, none of the buttons/links would work. We could perhaps improve caching and display that, but that's a lot of work for a very minor benefit in a niche scenario. I don't think it's worth the work. |
Github.com and GH:E server are independent entities, and failures can occur at each. However, I do not know how difficult it would be to change this behavior, so I respect the maintainer's decision. |
Oh, I misread 😅 Yeah that makes more sense. I think the requests could be more resilient for errors. |
I think gitify/src/hooks/useNotifications.ts Line 64 in f4053f5
@pddg - contributions welcomed 🙏 |
Environment
Expected behavior
Notification of github.com is appeared even if Gitify cannot reach GitHub Enterprise (GH:E) server (i.e. server downed, or disconnected from the networks of GH:E server...etc).
Actual behavior
In my environment, I use VPN to connect to GH:E server. Gitify doesn't send any notifications from github.com during disabling the VPN. If the VPN is enabled (Gitify becomes to be able to connect to GH:E server), Gitify send the notifications from both of github.com and GH:E.
The text was updated successfully, but these errors were encountered: