New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buttons must have discernible text #43

Open

koddsson opened this issue May 27, 2021 · 0 comments

Contributor

koddsson commented May 27, 2021

Just as we set the role=button for the markdown buttons:

markdown-toolbar-element/src/index.ts

Lines 100 to 102 in 731b52a

    
           if (!this.hasAttribute('role')) { 
        
             this.setAttribute('role', 'button') 
        
           }

We should also give them discernible text if it's not already set.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment