Add .timer & various other systemd extensions (fixes #7161)
#7163
Conversation
There was a problem hiding this comment.
How strictly does this project require "including a real-world usage sample for all extensions added in this PR"? I sure could copy/paste a random example from those "Search results for each extension" linked above, but... what's the point of that? (I'm happy to do so, if it's required to merge this, of course; just wasn't sure if really was a hard-requirement.)
It is. They're used to train the classifier.
Also every filename and extension needs to meet our usage requirements. One lesser used file or extension will hold up the PR until it meets the usage requirements.
| @@ -8468,10 +8468,28 @@ crontab: | |||
| language_id: 705203557 | |||
| desktop: | |||
| type: data | |||
| # https://en.wikipedia.org/wiki/INI_file | |||
There was a problem hiding this comment.
These are all in the wrong place. If they're INI files, we already have a section for that.
There was a problem hiding this comment.
These are all in the wrong place. If they're INI files, we already have a section for that.
But then the already existing (systemd) ".service" is in the wrong place as well? Do you want me to move that one too? Otherwise it's inconsistent. Full disclaimer: I don't yet fully understand what difference "desktop" (which are also INI) VS "ini" language makes either way. What I could do is raise a separate small PR, just to first move .service?
There was a problem hiding this comment.
ACK, thanks; I'll add samples.
Do you prefer separate small PRs - one for each? |
One PR is fine, and be sure to only include extensions that meet our usage requirements as the PR will be held up waiting for any that don't meet our requirements. |
Description
Fixes #7161.
Checklist:
How strictly does this project require "including a real-world usage sample for all extensions added in this PR"? I sure could copy/paste a random example from those "Search results for each extension" linked above, but... what's the point of that? (I'm happy to do so, if it's required to merge this, of course; just wasn't sure if really was a hard-requirement.)
PS: Please note this analysis for which extensions I have opted NOT to include.