Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add language: dyff #6348

Open
BogdanSorlea opened this issue Mar 28, 2023 · 4 comments
Open

Add language: dyff #6348

BogdanSorlea opened this issue Mar 28, 2023 · 4 comments
Labels
Add Language Good First Issue This is a great opportunity to start contributing to Linguist

Comments

@BogdanSorlea
Copy link

Language name

dyff

URL of example repository

https://github.com/homeport/dyff

URL of syntax highlighting grammar

TBD

Most popular extensions

unaware of extensions, if any

Detected language

N/A(?)

I would love to have dyff highlighting in code blocks on PRs. Initially I went down the path of having a highlight.js addition for this language, but then the github docs seem to suggest liguist as the way to go - to which I am opening this issue here.

@BogdanSorlea BogdanSorlea added Add Language Good First Issue This is a great opportunity to start contributing to Linguist labels Mar 28, 2023
@lildude
Copy link
Member

lildude commented Mar 28, 2023

I would love to have dyff highlighting in code blocks on PRs.

If I'm understanding you correctly, you're referring to the diff view on PRs, ie the "Files changed" tab. If so, this has nothing to do with Linguist. This is entirely within the main GitHub app code and is essentially a pretty git diff (with some enhancements for certain file types). Linguist is only responsible for providing the grammar for the language of the original files, which in this case would be the YAML syntax.

@github-linguist github-linguist deleted a comment from tisoi22 Apr 2, 2023
@BogdanSorlea
Copy link
Author

hey @lildude
your input is appreciated
I would like to try and send this request over to whoever is managing the core services at github, but I assume those are not public repos (and the public repos under https://github.com/github don't seem relevant / are hard to navigate anyways).
Do you know what would be the best way to achieve this?

Thanks.

@lildude
Copy link
Member

lildude commented Apr 12, 2023

Do you know what would be the best way to achieve this?

Yup. Hit the "Contact GitHub" link on any page, or reach out in the discussions at https://github.com/community

@BogdanSorlea
Copy link
Author

Thanks for your input.

For completion, I wrote this community post as product feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Add Language Good First Issue This is a great opportunity to start contributing to Linguist
Projects
None yet
Development

No branches or pull requests

2 participants