Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tutorial relies on deprecated functionnality (gko::lend) #1757

Open
rbourgeois33 opened this issue Dec 19, 2024 · 1 comment
Open

tutorial relies on deprecated functionnality (gko::lend) #1757

rbourgeois33 opened this issue Dec 19, 2024 · 1 comment

Comments

@rbourgeois33
Copy link

rbourgeois33 commented Dec 19, 2024

The tutorial: https://github.com/ginkgo-project/ginkgo/wiki/Tutorial-2:-Implement:-Matrices

Relies on the use of the gko::lend function that is deprecated according to my compile output:

no longer necessary, just pass the object without lend [-Wdeprecated-declarations] 56 | generate_stencil_matrix(gko::lend(matrix));

As I declared my matrix with:
auto matrix = gko::share(mtx::create(exec, gko::dim<2>(discretization_points)));, should I use generate_stencil_matrix(matrix.get()); ?

same in https://github.com/ginkgo-project/ginkgo/wiki/Tutorial-3:-Implement:-Solvers

gko::stop::ResidualNormReduction<>::build() has to be replaced with:
gko::stop::ResidualNorm<>::build() .with_baseline(gko::stop::mode::initial_resnorm) ?
(and a ';' has to be added at the end of .on(exec))

finally, for the solve:
solver->apply(rhs.get(), u.get());

Or is there a more up to date tutorial somewhere ?

Thanks in advance,
Rémi

@yhmtsai
Copy link
Member

yhmtsai commented Dec 19, 2024

Hi @rbourgeois33 ,
All modification you mentioned should be correct.
Yes, our tutorial in wiki is quite outdate. We are working on new version of tutorial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants