Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

read_raw should catch out-of-bounds indices(?) #1254

Open
upsj opened this issue Jan 9, 2023 · 0 comments
Open

read_raw should catch out-of-bounds indices(?) #1254

upsj opened this issue Jan 9, 2023 · 0 comments

Comments

@upsj
Copy link
Member

upsj commented Jan 9, 2023 •
edited
Loading

I just accidentally built a .mtx with 0-based indices, which caused the application to crash. I think we might be able to catch this kind of issue earlier without performance overhead, since read_raw is bottlenecked by string parsing and IO, not really the matrix_data itself.

Related to #770
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@upsj