Getting syntax errors on Windows with VS2017 ...

[shock-pro]

Hi Everyone,
I am using the released version ginkgo-1.3.0, CMAKE 3.20 finished fine, only 3 warnings for developers, nothing else.
Then exported the VS solutions fine, but then VS is having many syntax error as shown below:

Please, let me know how to fix this issue.
Thanks and Regards,

[yhmtsai]

Hi @shock-pro, thanks for reporting this issue.
we faced it in some tests before.
Could you try change {...} to (...)?
Could you also provide the VS2017 version?

[shock-pro]

Hi Yhmtsai!
That change fixed the issue. I don't think that curly braces are allowed in that context, are they ?
I am using:
C:\Program Files (x86)\Microsoft Visual Studio\2017\Community>cl
Microsoft (R) C/C++ Optimizing Compiler Version 19.16.27045 for x64

After fixing the curly braces, I am getting hundreds of errors:
For example:

Do you use VS to build Ginkgo often ?
Thanks!

[yhmtsai]

The error number is a little weird. Does it become C2397 on their website?
If it is list initialization such that it can not be narrowed conversion, it is weird gcc/clang pass them.
We have Github Action to use VS2019 to test compilation on reference/CUDA and running/compilation on reference.

[shock-pro]

Well, there are also hundreds of issues all related to the unsigned size_t used for gko::size_type

If you can change gko::size_type to a signed int, that would all the OMP for loops.
But I don't know if this may cause problems in other parts of the code.
Cheers,

[shock-pro]

I tried changing the definition of gko::size_type but as expected new incompatibility type errors appear in other places:

[yhmtsai]

please ignore the OMP error. We do not support OMP in MSVC.
you can use cmake -DGINKGO_BUILD_OMP=OFF .. to disable it.
the current develop branch disabling it automatically, but 1.3.0 still needs to turn off manually

[shock-pro]

If we modify gko::size_type to fix the C3016 issue, we get new issues in other places: