feat(GiniHealthSDK): Payment component documentation and integration guide IPC-98 #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added documentation for the classes, methods, and variables that are public from the payment component flow - Did some small cleaning IPC-98
…nent Added 2 photos of the payment component: The payment component view and the payment component screen IPC-98
…w initialization IPC-98
…documenting_payment_component
razvancapra
requested review from
zladzeyka,
ValentinaIancu-Gini and
a-szotyori
There was a problem hiding this comment.
Thank you @razvancapra for this pr.
I left some suggestions. We can discuss them if you need.
.../GiniHealthSDK/Sources/GiniHealthSDK/Core/PaymentComponent/PaymentComponentsController.swift
Outdated
Show resolved
Hide resolved
.../GiniHealthSDK/Sources/GiniHealthSDK/Core/PaymentComponent/PaymentComponentsController.swift
Outdated
Show resolved
Hide resolved
.../GiniHealthSDK/Sources/GiniHealthSDK/Core/PaymentComponent/PaymentComponentsController.swift
Outdated
Show resolved
Hide resolved
.../GiniHealthSDK/Sources/GiniHealthSDK/Core/PaymentComponent/PaymentComponentsController.swift
Outdated
Show resolved
Hide resolved
zladzeyka
requested changes
Feb 9, 2024
There was a problem hiding this comment.
@razvancapra thank you very much for the documentation! 👏🏻
Please, ignore for my comments about removing the empty lines 🙏
.../GiniHealthSDK/Sources/GiniHealthSDK/Core/PaymentComponent/PaymentComponentsController.swift
Outdated
Show resolved
Hide resolved
.../GiniHealthSDK/Sources/GiniHealthSDK/Core/PaymentComponent/PaymentComponentsController.swift
Outdated
Show resolved
Hide resolved
.../GiniHealthSDK/Sources/GiniHealthSDK/Core/PaymentComponent/PaymentComponentsController.swift
Outdated
Show resolved
Hide resolved
…documenting_payment_component
Formatting suggestions and rephrasing IPC-98
…from review Fixing suggestions from review. Rephrasing and adequate language IPC-98
zladzeyka
requested changes
Feb 16, 2024
…documenting_payment_component
…documenting_payment_component
…documenting_payment_component
…documenting_payment_component
…documenting_payment_component
…documenting_payment_component
…documenting_payment_component
…nt provider IPC-98
Base automatically changed from
IPC-110_payment-component-bank-available
to
ipc-health-sdk-update
February 26, 2024 14:29
zladzeyka
reviewed
Feb 27, 2024
.../GiniHealthSDK/Sources/GiniHealthSDK/Core/PaymentComponent/PaymentComponentsController.swift
Outdated
Show resolved
Hide resolved
zladzeyka
approved these changes
Feb 27, 2024
…Controller IPC-98 Co-authored-by: Nadzeya Karaban <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration.md