Pia 4596 rename feedback #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
zladzeyka
commented
Nov 2, 2023
•
zladzeyka
commented
- Deprecate old cleanup method
- Rename sendFeedback - > sendTransferSummary
- Extract cleanup () method
- Update tests
Cleanup PIA-4596
Cleanup PIA-4596
… cleanup methods Cleanup should be called after TAN verification PIA-4596
… cleanup methods Cleanup should be called after TAN verification, update test PIA-4596
…mmary Fix comments and tests PIA-4596
…ry, fix sending feedback for the lineItems Fix comments and tests PIA-4596
Refactor integration tests PIA-4596
...iniBankAPILibraryExample/GiniBankAPILibraryExampleTests/TransferSummaryIntegrationTest.swift
Show resolved
Hide resolved
...aryPinningExample/GiniBankAPILibraryPinningExampleTests/TransferSummaryIntegrationTest.swift
Show resolved
Hide resolved
BankSDK/GiniBankSDKExample/GiniBankSDKExample/Screen API/ScreenAPICoordinator.swift
Show resolved
Hide resolved
BankSDK/GiniBankSDKExample/Tests/TransferSummaryIntegrationTest.swift
Outdated
Show resolved
Hide resolved
CaptureSDK/GiniCaptureSDK/Sources/GiniCaptureSDK/Core/GiniConfiguration.swift
Outdated
Show resolved
Hide resolved
CaptureSDK/GiniCaptureSDKExample/Tests/TransferSummaryIntegrationTest.swift
Show resolved
Hide resolved
CaptureSDK/GiniCaptureSDKExample/Tests/TransferSummaryIntegrationTest.swift
Outdated
Show resolved
Hide resolved
CaptureSDK/GiniCaptureSDKPinningExample/Tests/TransferSummaryIntegrationTest.swift
Show resolved
Hide resolved
CaptureSDK/GiniCaptureSDKPinningExample/Tests/TransferSummaryIntegrationTest.swift
Outdated
Show resolved
Hide resolved
…eenAPIAndSendTransferSummary PIA-4596
ValentinaIancu-Gini
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.