Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pp 74 jira ticket post #635

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Pp 74 jira ticket post #635

wants to merge 6 commits into from

Conversation

GeraltRiv
Copy link
Contributor

@GeraltRiv GeraltRiv commented Nov 29, 2024

https://github.com/gini/gini-mobile-android/actions/runs/12084769854
THis works fine
In the task we can see links posted by bot. We need to change info in github secrets, to make some bot post this comments, not me
https://ginis.atlassian.net/browse/PP-74

Copy link
Contributor

@danicretu danicretu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

Copy link
Contributor

@abolfazlimahdi abolfazlimahdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Did you remove publishing to AppCenter from the workflows? If everything is working fine in Firebase, please remove AppCenter as well (ask Nadya before removing). Thank you!

@GeraltRiv
Copy link
Contributor Author

Looks good. Did you remove publishing to AppCenter from the workflows? If everything is working fine in Firebase, please remove AppCenter as well (ask Nadya before removing). Thank you!

I made it optional removed all push triggers. I think we can delete it when app center will be closed.

Copy link

sonarcloud bot commented Dec 12, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants