Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CiliumEniModeClusterBuilder #12

Closed
wants to merge 1 commit into from
Closed

Add CiliumEniModeClusterBuilder #12

wants to merge 1 commit into from

Conversation

AndiDog
Copy link
Contributor

@AndiDog AndiDog commented May 6, 2024

What does this PR do?

Towards giantswarm/roadmap#2563

Checklist

  • CHANGELOG.md has been updated

@AndiDog AndiDog requested a review from a team May 6, 2024 15:30
@AndiDog AndiDog requested a review from a team as a code owner May 6, 2024 15:30
@AverageMarcus
Copy link
Member

@AndiDog Do we really need a whole builder for this? This is something that could be done in a single test suite if that's the intention. Do you expect this to be used outside of cluster-test-suites? (e.g. with app tests and with CNCF Conformance)

@AndiDog
Copy link
Contributor Author

AndiDog commented May 7, 2024

@AndiDog Do we really need a whole builder for this? This is something that could be done in a single test suite if that's the intention. Do you expect this to be used outside of cluster-test-suites? (e.g. with app tests and with CNCF Conformance)

@AverageMarcus I wasn't sure. We have a builder for private clusters, for instance. Where else do we use these builders overall? I'm fine to instead use the standard builder and overriding the 2 Helm values in cluster-test-suites.

@AverageMarcus
Copy link
Member

We have a different builder for private because it also requires a different MC.

I think until we need to use this cluster configuration with anything other than cluster-test-suites it might be better to just have it as override values in the test suite in cluster-test-suites. It's easy enough to move it out if and when we do need to. 😄

That also means that you don't need to deal with new releases of this module to be able to make changes to it in cluster-test-suites.

What do you think? I'm happy either way, just sharing my opinion.

@AndiDog
Copy link
Contributor Author

AndiDog commented May 7, 2024

Yep makes sense.

@AndiDog AndiDog closed this May 7, 2024
@AndiDog AndiDog deleted the eni-mode branch May 7, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants