Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[naga] Forbid cycles between global expressions and types. #6800

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

[naga] Forbid cycles between global expressions and types. #6800

wants to merge 2 commits into from

Conversation

jimblandy
Copy link
Member

Update valid::handles to traverse Module::types and
Module::global_expressions in tandem, to ensure that the types and
expressions are acyclic.

Fixes #6793.

@jimblandy jimblandy added area: validation Issues related to validation, diagnostics, and error handling naga Shader Translator area: naga middle-end Intermediate representation labels Dec 21, 2024
@jimblandy jimblandy requested a review from a team as a code owner December 21, 2024 18:00
@jimblandy
[naga] Move type handle validation into its own function.
96445a9
@jimblandy
[naga] Forbid cycles between global expressions and types.
75a5565 
Update `valid::handles` to traverse `Module::types` and
`Module::global_expressions` in tandem, to ensure that the types and
expressions are acyclic.

Fixes gfx-rs#6793.
@jimblandy jimblandy force-pushed the naga-validate-override-sized-array-handles branch from 79d747d to 75a5565 Compare December 21, 2024 18:01
@jimblandy jimblandy mentioned this pull request Dec 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area: naga middle-end Intermediate representation area: validation Issues related to validation, diagnostics, and error handling naga Shader Translator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[naga] PendingArraySize::Expression handle not validated
1 participant
@jimblandy