Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep improving tests #14

Open
sckott opened this issue Oct 17, 2023 · 1 comment
Open

Keep improving tests #14

sckott opened this issue Oct 17, 2023 · 1 comment

Comments

@sckott
Copy link
Member

sckott commented Oct 17, 2023 •
edited
Loading

  • http request caching: looks like paws is using httr under the hood https://cran.r-project.org/web/packages/paws.common/index.html - should be able to use vcr to cache requests, speed up tests, hide secrets, etc.
  • be very sure no secrets are in fixtures
  • aws env vars need to be present within this github repo, but they don't need to be real
  • what else?
sckott added a commit that referenced this issue Oct 17, 2023
@sckott
#14 added testing infra, just 1 test file so far, tweak r check gh ac…
7faa883 
…tion to add dummy aws env vars
@sckott
Copy link
Member Author

sckott commented Oct 17, 2023

Infrastructure added. Add more tests, then close - will be an ongoing item to do of course

@sckott sckott changed the title Add tests Keep improving tests Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sckott