Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PACE-55] Improve hash transform #61

Open
ivan-p92 opened this issue Nov 16, 2023 · 0 comments
Open

[PACE-55] Improve hash transform #61

ivan-p92 opened this issue Nov 16, 2023 · 0 comments
Labels
enhancement New feature or request linear Created by Linear-GitHub Sync

Comments

@ivan-p92
Copy link
Contributor

ivan-p92 commented Nov 16, 2023

The current hash transform is implemented in the platform-agnostic DefaultProcessingPlatformTransformer. There are a couple issues with it:

  • The hashing functions differ across platforms, e.g. in their return types.
  • Hashing functions aren't really stable: the output type is typically a number or bytes, regardless of the input. This means that if a policy is created where for some principals the original value is returned, but for other the hashed value, a data type mismatch occurs.

The first issue can be resolved by creating platform-specific implementations, which is straightforward with the recent ProcessingPlatformTransformer interface.

The second issue requires additional thought. The hashed value could perhaps be cast to the original datatype or so. In the meantime, platform-specific hashing can be implemented using the SQL Statement transform.

PACE-56

@ivan-p92 ivan-p92 added enhancement New feature or request linear Created by Linear-GitHub Sync labels Nov 16, 2023
@ivan-p92 ivan-p92 changed the title Improve hash transform [PACE-55] Improve hash transform Nov 16, 2023
@ivan-p92 ivan-p92 changed the title [PACE-55] Improve hash transform [PACE-56] Improve hash transform Nov 16, 2023
@ivan-p92 ivan-p92 changed the title [PACE-56] Improve hash transform [PACE-55] [PACE-56] Improve hash transform Nov 16, 2023
@ivan-p92 ivan-p92 closed this as not planned Won't fix, can't repro, duplicate, stale Nov 16, 2023
@ivan-p92 ivan-p92 reopened this Nov 16, 2023
@ivan-p92 ivan-p92 added this to the v.1 milestone Nov 16, 2023
@ivan-p92 ivan-p92 changed the title [PACE-55] [PACE-56] Improve hash transform [PACE-55] Improve hash transform Nov 16, 2023
@ivan-p92 ivan-p92 removed this from the v.1 milestone Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request linear Created by Linear-GitHub Sync
Projects
None yet
Development

No branches or pull requests

1 participant