Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve consistency of GetBlueprintPolicy requests #175

Open
ivan-p92 opened this issue Jan 26, 2024 · 0 comments
Open

Improve consistency of GetBlueprintPolicy requests #175

ivan-p92 opened this issue Jan 26, 2024 · 0 comments
Labels
enhancement New feature or request linear Created by Linear-GitHub Sync

Comments

@ivan-p92
Copy link
Contributor

Problem description

The GetBlueprintPolicyRequests are not consistent with ResourceUrn anymore.

Processing platforms:

message GetBlueprintPolicyRequest {
    string platform_id = 1 [(buf.validate.field).string = {min_len: 1}];
    entities.v1alpha.Table table = 2;
    optional string fqn = 3;
}

Data catalogs:

message GetBlueprintPolicyRequest {
  string catalog_id = 1 [(buf.validate.field).string = {min_len: 1}];
  optional string database_id = 2;
  optional string schema_id = 3;
  string table_id = 4 [(buf.validate.field).string = {min_len: 1}];
  string fqn = 5;
}

Proposed solution
Consider refactoring the requests.

@ivan-p92 ivan-p92 added enhancement New feature or request linear Created by Linear-GitHub Sync labels Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request linear Created by Linear-GitHub Sync
Projects
None yet
Development

No branches or pull requests

1 participant