Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new macros for cargo does not accept more then one binary #3230

Open
2 tasks done
androidnisse opened this issue Jul 4, 2024 · 5 comments · May be fixed by getsolus/ypkg#90
Open
2 tasks done

new macros for cargo does not accept more then one binary #3230

androidnisse opened this issue Jul 4, 2024 · 5 comments · May be fixed by getsolus/ypkg#90
Labels
Feature Something can be enhanced. Tooling Tools and scripts

Comments

@androidnisse
Copy link
Contributor

Please confirm there isn't an existing open bug report

  • I have searched open bugs for this issue

Summary

When using %cargo_install it only accepts one binary. If more is needed a loop or using the macro multiple times is needed. See example in https://github.com/getsolus/packages/pull/3229/files

Steps to reproduce

  1. Build with more then one binary

Expected result

It installs all.

Actual result

It fails and falls backs to the package name.

Environment

  • Is system up to date?

Repo

Unstable

Desktop Environment

Budgie

System details

x

Other comments

Posted about this in package room on matrix.
@androidnisse androidnisse added the Bug Something isn't working label Jul 4, 2024
@androidnisse androidnisse mentioned this issue Jul 4, 2024
Open
@EbonJaeger EbonJaeger added Feature Something can be enhanced. Tooling Tools and scripts and removed Bug Something isn't working labels Jul 4, 2024
@EbonJaeger
Copy link
Member

How often does this actually come up? I would consider having to just do a loop in a package file a good tradeoff to the potential complexity of having the macro do it.

@androidnisse
Copy link
Contributor Author

androidnisse commented Jul 5, 2024 •
edited
Loading

How often does this actually come up? I would consider having to just do a loop in a package file a good tradeoff to the potential complexity of having the macro do it.

I have found this once for now. This can be looked at further when all packages use the macro.

Will add what I find here:
https://github.com/getsolus/packages/pull/3234/files
https://github.com/getsolus/packages/blob/main/packages/j/juliaup/package.yml
https://github.com/getsolus/packages/blob/main/packages/p/pueue/package.yml

@androidnisse
Copy link
Contributor Author

How often does this actually come up? I would consider having to just do a loop in a package file a good tradeoff to the potential complexity of having the macro do it.

Seems to be 4, see above comment. :)

@Staudey Staudey linked a pull request Jul 15, 2024 that will close this issue
Open
@Staudey
Copy link
Member

Staudey commented Jul 15, 2024

Would also save one line in ripgrep-all ^^

packages/packages/r/ripgrep-all/package.yml

Lines 25 to 26 in 2a91e45

%cargo_install rga
%cargo_install rga-preproc

@androidnisse
Copy link
Contributor Author

androidnisse commented Jul 15, 2024 •
edited
Loading

Would also save one line in ripgrep-all ^^

packages/packages/r/ripgrep-all/package.yml

Lines 25 to 26 in 2a91e45

%cargo_install rga
%cargo_install rga-preproc

Good catch 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Something can be enhanced. Tooling Tools and scripts
Projects
Solus
Status: Triage
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow multiple arguments to %cargo_install Staudey/ypkg
3 participants
@EbonJaeger @Staudey @androidnisse