Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TACOS reporting false plans #253

Open
mwarkentin opened this issue Aug 20, 2024 · 0 comments
Open

TACOS reporting false plans #253

mwarkentin opened this issue Aug 20, 2024 · 0 comments

Comments

@mwarkentin
Copy link
Member

Steps to Reproduce

  • Disk size was changed manually (bin/resize-disks most likely)
  • Make a terraform change to increase the disk beyond the current value

Expected Result

TACOS fetches proper "current" values for plan rendering

Actual Result

Local run:

# google_compute_disk.data["2-2"] will be updated in-place
  ~ resource "google_compute_disk" "data" {
        id                        = "projects/internal-sentry/zones/us-central1-b/disks/snuba-spans-mz-2-2-data"
        name                      = "snuba-spans-mz-2-2-data"
      ~ size                      = 22000 -> 26000
        # (13 unchanged attributes hidden)

TACOS run:

  # google_compute_disk.data["2-2"] will be updated in-place
  ~ resource "google_compute_disk" "data" {
        id                        = "projects/internal-sentry/zones/us-central1-b/disks/snuba-spans-mz-2-2-data"
        name                      = "snuba-spans-mz-2-2-data"
      ~ size                      = 20000 -> 26000
        # (13 unchanged attributes hidden)
    }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant