Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlock requirements are overly strict #214

Open
mwarkentin opened this issue May 9, 2024 · 1 comment
Open

Unlock requirements are overly strict #214

mwarkentin opened this issue May 9, 2024 · 1 comment

Comments

@mwarkentin
Copy link
Member

mwarkentin commented May 9, 2024

People other than the original author should be able to unlock PRs / slices. Currently this requires going outside of TACOS and using the CLI to do a terraform force-unlock.

With our distributed company, this can block someone for hours to a day depending on who has a lock.

tf-lock-release: failure: not [email protected]: .([email protected])

Alternative, keep the existing functionality but have a force-unlock option to bypass this check.

@lynnagara
Copy link
Member

here's an example: https://github.com/getsentry/ops/pull/11643#issuecomment-2263819530

i was trying to help a user with an ops request by requesting a plan on someone elses PR. This locked the PR so all future commits failed and attempts to unlock also failed due to this lock. It had to be manually unlocked over CLI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants