Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django related improvements / feedback #543

Open
BYK opened this issue Oct 31, 2024 · 0 comments
Open

Django related improvements / feedback #543

BYK opened this issue Oct 31, 2024 · 0 comments
Assignees
Labels
Type: Documentation Improvements or additions to documentation Type: Enhancement New feature or request

Comments

@BYK
Copy link
Member

BYK commented Oct 31, 2024

This is a braindump of feedback I got from a friend who tried to use Spotlight with Django:

Will be filing individual issues from these as I go.

@BYK BYK self-assigned this Oct 31, 2024
BYK added a commit to getsentry/sentry-python that referenced this issue Nov 5, 2024
This came as user feedback (getsentry/spotlight#543). Intentionally not making this part of Sentry logging as I think if one is enabling Spotlight, they should be seeing this in their logs, regardless of their SENTRY_DEBUG setting, which tends to be noisy.
BYK added a commit to getsentry/sentry-python that referenced this issue Nov 5, 2024
This came as user feedback (getsentry/spotlight#543). Intentionally not making this part of Sentry logging as I think if one is enabling Spotlight, they should be seeing this in their logs, regardless of their SENTRY_DEBUG setting, which tends to be noisy.
BYK added a commit to getsentry/sentry-python that referenced this issue Nov 12, 2024
This patch expands the `SpotlightMiddleware` for Django and injects the Spotlight button to all HTML responses when Spotlight is enabled and running. It requires Spotlight 2.6.0 to work this way.

Ref: getsentry/spotlight#543
@BYK BYK added Type: Documentation Improvements or additions to documentation Type: Enhancement New feature or request labels Nov 19, 2024
BYK added a commit to getsentry/sentry-python that referenced this issue Nov 19, 2024
Quick fix for getsentry/spotlight#543 until we implement a global scrubber that only scrubs events sent to the clound thorugh the DSN.
antonpirker added a commit to getsentry/sentry-python that referenced this issue Nov 21, 2024
* feat: Send PII to Spotlight when no DSN is set

Quick fix for getsentry/spotlight#543 until we implement a global scrubber that only scrubs events sent to the clound thorugh the DSN.

* add tests fix bugs

* Make scrubber initialization more explicit

* Refactored to not change the default value of send_default_pii

* Add test to show that there is now no way to opt out of sending PII to spotlight.

* Revert "Refactored to not change the default value of send_default_pii"

This reverts commit 15cf625.

* Revert "Add test to show that there is now no way to opt out of sending PII to spotlight."

This reverts commit de7f398.

---------

Co-authored-by: Anton Pirker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Documentation Improvements or additions to documentation Type: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant