-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Django related improvements / feedback #543
Labels
Type: Documentation
Improvements or additions to documentation
Type: Enhancement
New feature or request
Comments
This was referenced Oct 31, 2024
BYK
added a commit
that referenced
this issue
Nov 5, 2024
Ref #543 ![image](https://github.com/user-attachments/assets/407865d6-0e21-4608-8f8a-56f4948306c7) --------- Co-authored-by: Shubhdeep Chhabra <[email protected]>
BYK
added a commit
to getsentry/sentry-python
that referenced
this issue
Nov 5, 2024
This came as user feedback (getsentry/spotlight#543). Intentionally not making this part of Sentry logging as I think if one is enabling Spotlight, they should be seeing this in their logs, regardless of their SENTRY_DEBUG setting, which tends to be noisy.
BYK
added a commit
to getsentry/sentry-python
that referenced
this issue
Nov 5, 2024
This came as user feedback (getsentry/spotlight#543). Intentionally not making this part of Sentry logging as I think if one is enabling Spotlight, they should be seeing this in their logs, regardless of their SENTRY_DEBUG setting, which tends to be noisy.
BYK
added a commit
to getsentry/sentry-python
that referenced
this issue
Nov 12, 2024
This patch expands the `SpotlightMiddleware` for Django and injects the Spotlight button to all HTML responses when Spotlight is enabled and running. It requires Spotlight 2.6.0 to work this way. Ref: getsentry/spotlight#543
BYK
added
Type: Documentation
Improvements or additions to documentation
Type: Enhancement
New feature or request
labels
Nov 19, 2024
BYK
added a commit
to getsentry/sentry-python
that referenced
this issue
Nov 19, 2024
Quick fix for getsentry/spotlight#543 until we implement a global scrubber that only scrubs events sent to the clound thorugh the DSN.
antonpirker
added a commit
to getsentry/sentry-python
that referenced
this issue
Nov 21, 2024
* feat: Send PII to Spotlight when no DSN is set Quick fix for getsentry/spotlight#543 until we implement a global scrubber that only scrubs events sent to the clound thorugh the DSN. * add tests fix bugs * Make scrubber initialization more explicit * Refactored to not change the default value of send_default_pii * Add test to show that there is now no way to opt out of sending PII to spotlight. * Revert "Refactored to not change the default value of send_default_pii" This reverts commit 15cf625. * Revert "Add test to show that there is now no way to opt out of sending PII to spotlight." This reverts commit de7f398. --------- Co-authored-by: Anton Pirker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Type: Documentation
Improvements or additions to documentation
Type: Enhancement
New feature or request
This is a braindump of feedback I got from a friend who tried to use Spotlight with Django:
cache_spans
in Django integration on SDK side for this (feat(spotlight): Auto enable cache_spans for Spotlight on DEBUG sentry-python#3791)DEBUG
setting orSENTRY_DEBUG
in the SDK) (feat(spotlight): Add info logs when Sentry is enabled sentry-python#3735)[send_default_pii](https://docs.sentry.io/platforms/python/configuration/options/#send-default-pii)
. We can enable this when Spotlight is enabled but then we risk sending this upstream to Sentry if there's a DSN set too. For now, we can limit this toDEBUG
mode or lack ofDSN
for automatic turn-on behavior but looks like we need larger architectural changes for this such as post-scrubbing instead of limiting at the time of collection. (feat: Send PII to Spotlight when no DSN is set sentry-python#3804)Transactions under-- We capture these/admin
doesn't seem to be captured (intentional by the SDK?)Will be filing individual issues from these as I go.
The text was updated successfully, but these errors were encountered: