Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error messaging for unresolved metrics errors #6084

Closed
evanh opened this issue Jul 2, 2024 · 1 comment · Fixed by #6244
Closed

Better error messaging for unresolved metrics errors #6084

evanh opened this issue Jul 2, 2024 · 1 comment · Fixed by #6244

Comments

@evanh
Copy link
Member

evanh commented Jul 2, 2024

When a column isn't resolved properly, the query returns an ambiguous error message.

validation failed for entity generic_metrics_distributions: Entity generic_metrics_distributions: Query column 'wrapper_type' does not exist

This should return a more obvious "tag key not resolved error" or something along those lines.
@vgrozdanic vgrozdanic mentioned this issue Jun 19, 2024
Closed
@onkar
Copy link
Member

onkar commented Aug 27, 2024

@vgrozdanic the error is coming from here:

snuba/snuba/query/validation/validators.py

Line 186 in d4b164c

error_message = (
Do you have any preference on the error message text? I am not following the "tag key not resolved error" message in the issue description and would appreciate some help in wording. Thanks.

@onkar onkar mentioned this issue Aug 27, 2024
Merged
onkar added a commit that referenced this issue Aug 27, 2024
@onkar
Emit better error message when a column is not resolved properly (#6244)
e2b5fac 
When a column/columns is/are not resolved, the query returns ambiguous
error message like:
`validation failed for entity generic_metrics_distributions: Entity
generic_metrics_distributions: Query column 'wrapper_type' does not
exist`.

This needs to be fixed to show a more readable message:
`Validation failed for entity generic_metrics_distributions: Tag keys
(wrapper_type) not resolved`

Closes #6084

**Testing done:**
Fixed unit tests
@onkar onkar mentioned this issue Aug 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Emit better error message when a column is not resolved properly getsentry/snuba
2 participants
@onkar @evanh