feat(processing): add electron symbol server to default for electron projects #81118
+61
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
shellmayr
changed the title
jan-auer
reviewed
Nov 21, 2024
Comment on lines
135
to
139
| # Add electron symbol server by default to both electron and javascript-electron projects | ||
| if project.platform and project.platform in ["electron", "javascript-electron"]: | ||
| project.update_option( | ||
| "sentry:builtin_symbol_sources", ["ios", "microsoft", "electron"] | ||
| ) |
There was a problem hiding this comment.
It looks like the project_created signal is intentionally sent at the very end just before returning the project. Could you reorder this accordingly?
Comment on lines
225
to
230
| # Add electron symbol server by default to both electron and javascript-electron projects | ||
| if project.platform and project.platform in ["electron", "javascript-electron"]: | ||
| project.update_option( | ||
| "sentry:builtin_symbol_sources", ["ios", "microsoft", "electron"] | ||
| ) | ||
|
|
There was a problem hiding this comment.
This does a very similar thing as set_default_inbound_filters above. Two suggestions
- Move it up so both of these are placed together. Going forward, this is a good place to add new, similar functionality.
- Create a helper function that you can also call from the
DatabaseBackedProjectService.
There was a problem hiding this comment.
Yeah I was pondering that, but then we set the seer project option sentry:similarity_backfill_completed below, so I followed that lead. But good points, rearranged and pulled it into a helper function.
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #81118 +/- ##
==========================================
- Coverage 78.48% 78.47% -0.01%
==========================================
Files 7215 7216 +1
Lines 319848 319857 +9
Branches 44058 44060 +2
==========================================
- Hits 251019 251017 -2
- Misses 62438 62445 +7
- Partials 6391 6395 +4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For projects with platforms
electronandjavascript-electron, add the public electron symbol server to the list of default symbol servers during project creation.Closes #80891