Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(instrumentation): Fix false double leading slashes in transaction names #80124

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

gggritso
Copy link
Member

@gggritso gggritso commented Nov 1, 2024

See comment in details. Prevents errors and transaction events with names like "//dashboards/:dashboardId" caused by a bad interaction between React Router 6 instrumentation in the SDK and our shimming setup.

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 1, 2024
@getsantry
Copy link
Contributor

getsantry bot commented Nov 22, 2024

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant